Add "code" (shell) linter and format checker #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmach
force-pushed
the
main
branch
4 times, most recently
from
9f7e03f to
9815e12
Compare
This uses: - shellcheck - shfmt behind the scenes
paulo-ferraz-oliveira
force-pushed
the
feature/checks
branch
from
88e1a52 to
87132f8
Compare
|
Now that #1 is out this is rebased on top of the default branch. |
paulo-ferraz-oliveira
force-pushed
the
feature/checks
branch
from
ed43508 to
878b92b
Compare
|
Branch is updated and rebased on top of the default branch. Lemme know what you want relaxed, commented, removed, etc. |
paulo-ferraz-oliveira
force-pushed
the
main
branch
3 times, most recently
from
805b320 to
e416e5e
Compare
starbelly
reviewed
Nov 13, 2024
| @@ -118,7 +118,7 @@ test_otp() { | |||
| {ok, _} = application:ensure_all_started(crypto), io:format("crypto ok~n"), | |||
| halt().' | |||
|
|
|||
| if dyld_info ${OTP_DIR}/lib/crypto-*/priv/lib/crypto.so | tail -n +2 | grep -q openssl; then | |||
| if dyld_info "${OTP_DIR}/lib/crypto-*/priv/lib/crypto.so" | tail -n +2 | grep -q openssl; then | |||
|
As with the other one, I'm merging and it should be easy to revert if it causes issues in the default branch. |
wojtekmach
reviewed
Nov 14, 2024
| @@ -0,0 +1,34 @@ | |||
| --- | |||
| "on": | |||
There was a problem hiding this comment.
"on"
I'm not a fan of this particular change but I get it and it's obviously not a deal breaker. Thank you for the PR!
There was a problem hiding this comment.
We can revert it. It's an option for the linter. I'll do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses:
behind the scenes.
After #1 is merged I don't mind either relaxing the rules or adapting the code. I've found, over use, that at least ShellCheck is very good at catching error-prone patterns and even helping make it more readable.
Closes #13.
Closes #14.