Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdlib: Fix argparse:format_help/2 crash on 'hidden' command #9151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

stdlib: Fix argparse:format_help/2 crash on 'hidden' command #9151

wants to merge 1 commit into from
+18 −0

Conversation

sg2342
Copy link
Contributor

@sg2342 sg2342 commented Dec 6, 2024

Fixes #9150

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024 •
edited
Loading

CT Test Results

    2 files     96 suites   1h 8m 52s ⏱️
2 172 tests 2 123 ✅ 48 💤 1 ❌
2 535 runs  2 484 ✅ 50 💤 1 ❌

For more details on these failures, see this check.

Results for commit ac6c4da.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

max-au
max-au approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@max-au max-au left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for adding the test case for explicitly added sub-command. Looks good to me.

@garazdawi garazdawi self-assigned this Dec 6, 2024
@garazdawi garazdawi added team:VM Assigned to OTP team VM fix labels Dec 6, 2024
@garazdawi
Copy link
Contributor

Thanks for the fix. I will merge this to maint for release in 27.3 as soon as 27.2 is out.

@garazdawi garazdawi added this to the OTP-27.3 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-au max-au max-au approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@garazdawi garazdawi

Labels
fix team:VM Assigned to OTP team VM
Projects
None yet
Milestone
OTP-27.3
Development

Successfully merging this pull request may close these issues.

argparse crash in format_help for hidden commands
3 participants
@sg2342 @garazdawi @max-au