stdlib: Fix preorder and postorder traversals in digraph_utils
#9171
+56
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 2 files 96 suites 1h 7m 56s ⏱️ For more details on these failures, see this check. Results for commit f1f456c. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
lucioleKi
added
the
testing
bjorng
reviewed
Dec 10, 2024
The previous `digraph_utils:preorder/1` and `digraph_utils:postorder/1` did not start the traversal from root nodes. This fix makes both traversals only start or restart from a root node in one of the components, or an arbitrary node if no root node can be visited. Since in the previous version, the search can start and restart from arbitrary nodes, this fix should not break backwards compatibility. It is worth noting that the digraph does not have a notion of a left or right subtree. The result of both traversals may not be the same after relabelling vertices.
lucioleKi
force-pushed
the
isabell/stdlib/digraph_traversals
branch
from
604cab1 to
f1f456c
Compare
bjorng
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous
digraph_utils:preorder/1anddigraph_utils:postorder/1did not start the traversal from root nodes. This fix makes both traversals only start or restart from a root node in one of the components, or an arbitrary node if no root node can be visited. Since in the previous version, the search can start and restart from arbitrary nodes, this fix should not break backwards compatibility.It is worth noting that the digraph does not have a notion of a left or right subtree. The result of both traversals may not be the same after relabelling vertices.