-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exception is shown when I compare two selection version from version history #59
Comments
Thanks for the report! Do you get this with any file, all the time? It may be something with the SVN provider, I will try that too (I can't reproduce with git). |
I just tried with Subversive plugin and the following file, and it works as it should. Could you please give me more details so that I can reproduce? -module(demo).
-export([info/0]).
info() ->
[
{data, "this is just a test"},
{data, "this is just a test"}
]. |
It seems I can always produce it in my environment. If you need any trace, please let me know. If this two bugs(see below description for another one) can be fixed, it will be very helpful for me, and I am willing to do anything for it . In addition, Nothing is show when I right click a file and select "Compare with" -> "Latest from repository". I report this issue some days ago. !ENTRY org.eclipse.ui 4 0 2012-06-01 10:21:13.790 |
Please send me your configuration (help->about->installation details->configuration). Did you try with a simple file like the one I gave as example above? If yes, please try again, and modify it by first adding a line of code, and then by removing one. Do both cases fail? The problem is that when comparing, the old versions aren't in files and something tries to apply syntax highlighting that belongs to the other file. We'll have to find out why it happens. |
sent our the configuration by mail. In addition, I can’t try the simple file since I’m in my production dev environment. |
Ok, I'll see what I can do, I will use a similar configuration. If I can't reproduce, I will still ask you to try to create a local SVN repo on your machine and see how it works with the demo file. |
I tried a very simple file. First, the comparison works well. But Later, I tried a project file, it can't work. And I go back to try the simple file, it then also can't work. Below is the very simple file I used. %% @auth chenqiliang -export([fib/1]). -export([my_func/0]). my_func() -> fib(0) -> 0; What I changed is from "hello |
When I restart my eclipse, and compare the simple file with latest file from SVN. It still can not work |
Hello guys, I have the similar issue with 0.17.2 version of erlide. Here is the stacktrace
|
Are you comparing with a version from version control? Is it subversion or something else? which plugin? This is a difficult problem, because as you can see in the stacktrace, no erlide code is involved directly. Unless I can reproduce it, I can only guess about what happens. I believe the problem is that when comparing, the VCS version doesn't have a file as "ground" and the syntax coloring chokes. We will look at this again. Thanks for the report! |
Hello Vlad, Svn plugin is subversive. |
Thanks fo the info, I will try to reproduce it. |
@szhem : Do you get the same thing if you compare two versions from the local history? |
With local history everything works fine without exceptions. |
Ok, thanks. I can't reproduce your problem yet, but I get a different weird behaviour for some files (i.e. nothing is shown). It's something with the interaction with the VCS plugins... Digging further. |
Is this still a problem? The latest nightlies (0.24.0) have some fixes that are related to problems when diffing versions. |
I assume this to be working now. Please reopen if this is not the case. |
Finally fixed with #307 |
I select a .erl and right click it and select team -> show history
I the version history view, I select two version, right click and select "compare ..."
I can not see the comparing result in editor, but an empty editor without anything. Below is the exception logged in .log file
!ENTRY org.eclipse.ui 4 0 2012-05-31 13:45:08.783
!MESSAGE Unhandled event loop exception
!STACK 0
org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.IllegalArgumentException: Argument not valid)
at org.eclipse.swt.SWT.error(SWT.java:4282)
at org.eclipse.swt.SWT.error(SWT.java:4197)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:138)
at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4140)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3757)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2701)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2665)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2499)
at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:679)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:668)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:123)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
Caused by: java.lang.IllegalArgumentException: Argument not valid
at org.eclipse.swt.SWT.error(SWT.java:4263)
at org.eclipse.swt.SWT.error(SWT.java:4197)
at org.eclipse.swt.SWT.error(SWT.java:4168)
at org.eclipse.swt.custom.StyledText.setStyleRanges(StyledText.java:9680)
at org.eclipse.swt.custom.StyledText.replaceStyleRanges(StyledText.java:7713)
at org.eclipse.jface.text.TextViewer.addPresentation(TextViewer.java:4811)
at org.eclipse.jface.text.TextViewer.changeTextPresentation(TextViewer.java:4890)
at org.eclipse.jface.text.presentation.PresentationReconciler.applyTextRegionCollection(PresentationReconciler.java:579)
at org.eclipse.jface.text.presentation.PresentationReconciler.processDamage(PresentationReconciler.java:568)
at org.eclipse.jface.text.presentation.PresentationReconciler.access$3(PresentationReconciler.java:564)
at org.eclipse.jface.text.presentation.PresentationReconciler$InternalListener.textChanged(PresentationReconciler.java:225)
at org.eclipse.jface.text.TextViewer.updateTextListeners(TextViewer.java:2824)
at org.eclipse.jface.text.TextViewer.invalidateTextPresentation(TextViewer.java:3444)
at org.eclipse.compare.contentmergeviewer.TextMergeViewer.invalidateTextPresentation(TextMergeViewer.java:1692)
at org.eclipse.compare.contentmergeviewer.TextMergeViewer.doDiff(TextMergeViewer.java:3283)
at org.eclipse.compare.contentmergeviewer.TextMergeViewer.update(TextMergeViewer.java:4999)
at org.eclipse.compare.contentmergeviewer.TextMergeViewer.updateContent(TextMergeViewer.java:2847)
at org.eclipse.compare.contentmergeviewer.ContentMergeViewer.internalRefresh(ContentMergeViewer.java:743)
at org.eclipse.compare.contentmergeviewer.ContentMergeViewer.inputChanged(ContentMergeViewer.java:643)
at org.eclipse.jface.viewers.ContentViewer.setInput(ContentViewer.java:280)
at org.eclipse.compare.CompareViewerSwitchingPane.setInput(CompareViewerSwitchingPane.java:277)
at org.eclipse.compare.internal.CompareContentViewerSwitchingPane.setInput(CompareContentViewerSwitchingPane.java:158)
at org.eclipse.compare.CompareEditorInput.internalSetContentPaneInput(CompareEditorInput.java:845)
at org.eclipse.compare.CompareEditorInput.access$8(CompareEditorInput.java:843)
at org.eclipse.compare.CompareEditorInput$11.run(CompareEditorInput.java:779)
at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
at org.eclipse.compare.CompareEditorInput.feed1(CompareEditorInput.java:773)
at org.eclipse.compare.CompareEditorInput.feedInput(CompareEditorInput.java:751)
at org.eclipse.compare.CompareEditorInput.createContents(CompareEditorInput.java:555)
at org.tigris.subversion.subclipse.ui.compare.SVNAbstractCompareEditorInput.createContents(SVNAbstractCompareEditorInput.java:44)
at org.eclipse.compare.internal.CompareEditor.createCompareControl(CompareEditor.java:462)
at org.eclipse.compare.internal.CompareEditor.access$6(CompareEditor.java:422)
at org.eclipse.compare.internal.CompareEditor$3.run(CompareEditor.java:378)
at org.eclipse.ui.internal.UILockListener.doPendingWork(UILockListener.java:164)
at org.eclipse.ui.internal.UISynchronizer$3.run(UISynchronizer.java:158)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
... 22 more
The text was updated successfully, but these errors were encountered: