Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: restore account code hash in HashState unwind #2580

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

canepat
Copy link
Member

@canepat canepat commented Dec 10, 2024

We need to restore the code hash into the account during the HashState unwind procedure when we encounter an account having non-zero incarnation and empty code hash.

Extras

  • improve error logs
  • avoid some CLion warnings

@canepat canepat added the maintenance Some maintenance work (fix, refactor, rename, test...) label Dec 10, 2024
@canepat canepat linked an issue Dec 12, 2024 that may be closed by this pull request
@canepat canepat marked this pull request as ready for review December 12, 2024 07:50
Copy link
Contributor

@battlmonstr battlmonstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👼

@battlmonstr battlmonstr merged commit fa7a2e0 into master Dec 12, 2024
6 checks passed
@battlmonstr battlmonstr deleted the fix/hashstate_unwind_code_hash_restore branch December 12, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Some maintenance work (fix, refactor, rename, test...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

silkworm: wrong state root after reorg at chain tip
2 participants