tidy: upgrade to v18 (#2277) (#2346)

erigontech · Sep 12, 2024 · 1873b12 · 1873b12
1 parent cfe61b1
commit 1873b12
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -337,7 +337,8 @@ jobs:
           name: "Install clang-tidy"
           command: |
             sudo apt-get update
-            sudo apt-get install -y clang-tidy
+            sudo apt-get install -y clang-tidy-<<pipeline.parameters.clang_version_latest>>
+            sudo update-alternatives --install /usr/bin/clang-tidy clang-tidy /usr/bin/clang-tidy-<<pipeline.parameters.clang_version_latest>> 100
       - checkout_with_submodules:
           ethereum_tests: false
       - build_using_conan:
@@ -356,7 +357,8 @@ jobs:
           name: "Install clang-tidy"
           command: |
             sudo apt-get update
-            sudo apt-get install -y clang-tidy
+            sudo apt-get install -y clang-tidy-<<pipeline.parameters.clang_version_latest>>
+            sudo update-alternatives --install /usr/bin/clang-tidy clang-tidy /usr/bin/clang-tidy-<<pipeline.parameters.clang_version_latest>> 100
       - checkout_with_submodules:
           ethereum_tests: false
       - build_using_conan:

diff --git a/cmd/dev/snapshots.cpp b/cmd/dev/snapshots.cpp
@@ -832,6 +832,7 @@ void sync(const SnapshotSettings& settings) {
     auto chaindata_env = db::open_env(chaindata_env_config);
     test_util::TaskRunner runner;
     NoopStageSchedulerAdapter stage_scheduler;
+    // NOLINTNEXTLINE(cppcoreguidelines-slicing)
     db::SnapshotSync snapshot_sync{settings, kMainnetConfig.chain_id, chaindata_env, tmp_dir.path(), stage_scheduler};
     runner.run(snapshot_sync.download_snapshots());
     std::chrono::duration elapsed{std::chrono::steady_clock::now() - start};