Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain: figure out why do we close cursor every time #13089

Closed
AskAlexSharov opened this issue Dec 12, 2024 · 1 comment
Closed

domain: figure out why do we close cursor every time #13089

AskAlexSharov opened this issue Dec 12, 2024 · 1 comment
Assignees
@awskii
Labels
erigon3 imp2 Medium importance
Milestone
3.0.0-beta1

Comments

@AskAlexSharov
Copy link
Collaborator

AskAlexSharov commented Dec 12, 2024 •
edited
Loading 

func (dt *DomainRoTx) valsCursor(tx kv.Tx) (c kv.Cursor, err error) {
	if dt.valsC != nil {
		dt.valsC.Close()
		dt.valsC = nil
	}

maybe it's related with #12546 (comment)
@AskAlexSharov AskAlexSharov added imp2 Medium importance erigon3 labels Dec 12, 2024
@AskAlexSharov AskAlexSharov added this to the 3.0.0-beta2 milestone Dec 12, 2024
@AskAlexSharov AskAlexSharov changed the title figure out why do we close cursor every time domain: figure out why do we close cursor every time Dec 12, 2024
@awskii
Copy link
Member

awskii commented Dec 18, 2024

fixed by #12546

@awskii awskii closed this as completed Dec 18, 2024
@yperbasis yperbasis modified the milestones: 3.0.0-beta2, 3.0.0-beta1 Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@awskii awskii

Labels
erigon3 imp2 Medium importance
Projects
None yet
Milestone
3.0.0-beta1
Development

No branches or pull requests
3 participants
@awskii @yperbasis @AskAlexSharov