Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tm Theme Editor #1

Open
earlev4 opened this issue Apr 2, 2020 · 14 comments
Open

Tm Theme Editor #1

earlev4 opened this issue Apr 2, 2020 · 14 comments

Comments

@earlev4
Copy link

earlev4 commented Apr 2, 2020

Hi!

Good day to you! I greatly appreciate the efforts and work going into the a11y-syntax-highlighting project. I have seen much positive feedback on A11y Dark theme on Carbon and I share that sentiment. A11y Dark is one of the best themes I have seen in a while. Are you aware of any efforts to add A11y Dark theme to the Tm Theme Editor Website?

https://tmtheme-editor.herokuapp.com/#!/editor/theme/Monokai

I would be happy to assist to build one but would need to know all of the possible scope names and associated foreground/background hex values. I would not want to make any assumptions and diverge from the appropriate color theme.

Thanks so much!

@ericwbailey
Copy link
Owner

Hey there! Thank you for the kind words, it means a lot to me.

I've got color names and values listed in the README for the dark and light themes, as well as their corresponding WCAG level of compliance when placed on the background color.

If you want to create a PR for tmTheme Editor, I say go for it! I'd appreciate a link when you're done, just to check it out 🙂

@alamodey
Copy link

alamodey commented Dec 9, 2020

can you make a theme for Xcode as well?

@ericwbailey
Copy link
Owner

@alamodey Great idea! I'll start chipping away at it.

@ericwbailey
Copy link
Owner

@alamodey I added a dark mode theme for Xcode: https://github.com/ericwbailey/a11y-syntax-highlighting/tree/main/dist/xcode

I don't spend a lot of time in that editor. Does it feel right to you? If so, I'll whip up a light theme. Happy to make tweaks, too.

@alamodey
Copy link

Screen Shot 2020-12-11 at 5 18 13 pm

It looks a bit different to what I expected

@ericwbailey
Copy link
Owner

Are you sure the correct theme is highlighted? This is how the preview looks on my end of things:

The 'A11Y Dark' theme selected in Xcode, with exampled colored code tokens.

@alamodey
Copy link

Screen Shot 2020-12-12 at 10 02 03 am

@alamodey
Copy link

Is it because I'm in dark mode?

@ericwbailey
Copy link
Owner

Oh, I think I got it!

Set your colors to the following:

  • Background: #2B2B2B
  • Current Line: #000000
  • Selection: #000000
  • Cursor: #FFFFFF
  • Invisibles: #565655

I assumed these values were included as part of the theme data, but it appears that they're not?

@alamodey
Copy link

alamodey commented Dec 12, 2020

There must be a way to include it in the theme data because all the other themes I download on Xcode work fine.

Perhaps you need to temporarily change your MacOS to dark mode and then set the colours again.

@ericwbailey
Copy link
Owner

Yeah, I'll investigate. So weird.

@ericwbailey
Copy link
Owner

So, I tried toggling dark mode on and off and the background, current line color, etc. persist. I'm also not seeing an option to include those values in the export, as exporting is just copying the .xccolortheme out of ~/Library/Developer/Xcode/UserData/FontAndColorThemes/.

Do you know of another way to export?

@alamodey
Copy link

I am not familiar with creating themes but what if you went to the github of another theme like this: https://github.com/bojan/xcode-one-dark

and just replace their colours with yours?

@ericwbailey
Copy link
Owner

I just ran through and manually compared those key definitions with what I have. Weirdly, I have more, but nothing in either theme that speaks to the missing background color, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants