-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tm Theme Editor #1
Comments
Hey there! Thank you for the kind words, it means a lot to me. I've got color names and values listed in the README for the dark and light themes, as well as their corresponding WCAG level of compliance when placed on the background color. If you want to create a PR for tmTheme Editor, I say go for it! I'd appreciate a link when you're done, just to check it out 🙂 |
can you make a theme for Xcode as well? |
@alamodey Great idea! I'll start chipping away at it. |
@alamodey I added a dark mode theme for Xcode: https://github.com/ericwbailey/a11y-syntax-highlighting/tree/main/dist/xcode I don't spend a lot of time in that editor. Does it feel right to you? If so, I'll whip up a light theme. Happy to make tweaks, too. |
Is it because I'm in dark mode? |
Oh, I think I got it! Set your colors to the following:
I assumed these values were included as part of the theme data, but it appears that they're not? |
There must be a way to include it in the theme data because all the other themes I download on Xcode work fine. Perhaps you need to temporarily change your MacOS to dark mode and then set the colours again. |
Yeah, I'll investigate. So weird. |
So, I tried toggling dark mode on and off and the background, current line color, etc. persist. I'm also not seeing an option to include those values in the export, as exporting is just copying the Do you know of another way to export? |
I am not familiar with creating themes but what if you went to the github of another theme like this: https://github.com/bojan/xcode-one-dark and just replace their colours with yours? |
I just ran through and manually compared those |
Hi!
Good day to you! I greatly appreciate the efforts and work going into the a11y-syntax-highlighting project. I have seen much positive feedback on A11y Dark theme on Carbon and I share that sentiment. A11y Dark is one of the best themes I have seen in a while. Are you aware of any efforts to add A11y Dark theme to the Tm Theme Editor Website?
https://tmtheme-editor.herokuapp.com/#!/editor/theme/Monokai
I would be happy to assist to build one but would need to know all of the possible scope names and associated foreground/background hex values. I would not want to make any assumptions and diverge from the appropriate color theme.
Thanks so much!
The text was updated successfully, but these errors were encountered: