Fixes for snowflake

Author: erezsh

preql/core/sql.py

@@ -1096,7 +1096,7 @@ def compile_type_def(table_name, table) -> Sql:
                         posts.append(s)
 
     if pks and db.supports_foreign_key: 
-        names = ", ".join(pks)
+        names = ", ".join(map(quote_name, pks))
         posts.append(f"PRIMARY KEY ({names})")
 
     # Consistent among SQL databases

preql/modules/__builtins__.pql

@@ -398,6 +398,7 @@ if (db_type == "postgres" or db_type == "redshift") {
     func commit() = null
 } else if (db_type == "snowflake") {
     func _random() = SQL(float, "uniform(0::float, 1, random())")
+    func _now() = SQL(timestamp, "CURRENT_TIMESTAMP()")
     //
 } else if (db_type == "presto") {
     //

preql/sql_interface.py

@@ -499,14 +499,22 @@ def __init__(self, account, user, password, warehouse, schema, database, role=No
             schema=schema,
         )
 
+        self._schema = schema
         self._print_sql = print_sql
 
-    def commit(self):
-        self._client.commit()
+    def qualified_name(self, name):
+        "Ensure the name has a dataset"
+        assert isinstance(name, Id)
+        if len(name.parts) > 1:
+            # already has dataset
+            return name
+        return Id(self._schema, name.parts[-1])
 
     def quote_name(self, name):
-        # TODO is this right?
-        return name
+        return f'"{name}"'
+
+    def commit(self):
+        self._client.commit()
 
     def table_exists(self, name):
         assert isinstance(name, Id)
@@ -576,6 +584,7 @@ def _import_result(self, sql_type, c):
             raise DatabaseQueryError(msg%(e))
 
         return sql_result_to_python(Const(sql_type, res))
+
     def _execute_sql(self, sql_type, sql_code):
         import snowflake.connector
         cs = self._client.cursor()