Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate transaction cost calculations using the re_execute tool #2450

Closed
kkovaacs opened this issue Dec 18, 2024 · 2 comments
Closed

Validate transaction cost calculations using the re_execute tool #2450

kkovaacs opened this issue Dec 18, 2024 · 2 comments
Assignees
@kkovaacs
Milestone
Starknet 0.13.4

Comments

@kkovaacs
Copy link
Contributor

We should check that:

  • Fees for old transactions (starting from 0.13.2) are calculated correctly. Ideally Starknet main should be used to maximize coverage.
  • Fees for 0.13.4 transactions (using L2 gas) are calculated correctly. This can only be done on the integration chain.
@kkovaacs kkovaacs added this to the Starknet 0.13.4 milestone Dec 18, 2024
@kkovaacs kkovaacs self-assigned this Jan 9, 2025
@kkovaacs
Copy link
Contributor Author

There's an issue with the binary search fee estimation vs. simulation. PR #2608 has a more detailed description on the problem.

@kkovaacs
Copy link
Contributor Author

After fixing the issue with simulation we seem to be able to get matching results both for 0.13.3 blocks (on mainnet) and 0.13.4 blocks (on the Sepolia integration network).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkovaacs kkovaacs

Labels
None yet
Projects
pathfinder
Status: Done
Milestone
Starknet 0.13.4
Development

No branches or pull requests
1 participant
@kkovaacs