Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2P: checkpoint sync fails on a malicious peer #2102

Closed
CHr15F0x opened this issue Jun 26, 2024 · 2 comments
Closed

P2P: checkpoint sync fails on a malicious peer #2102

CHr15F0x opened this issue Jun 26, 2024 · 2 comments
Milestone
P2P sync

Comments

@CHr15F0x
Copy link
Member

Right now checkpoint sync does not retry if it encounters an error, neither does it punish the peer that produces data that failed verification.

Checkpoint sync should:

  • punish the offending peer, just similarly to what the p2p client does,
  • retry upon reaching an error related to malicious peer/data, the p2p client will then reach out to the current set of peers minus the last offending peer.
@CHr15F0x CHr15F0x added the bug Something isn't working label Jun 26, 2024
@CHr15F0x CHr15F0x changed the title Checkpoint sync fails on a malicious peer P2P: checkpoint sync fails on a malicious peer Jun 26, 2024
@CHr15F0x CHr15F0x removed the bug Something isn't working label Jul 5, 2024
@CHr15F0x
Copy link
Member Author

CHr15F0x commented Jul 5, 2024

Removing the bug label because it's a missing feature not a real bug.

@kkovaacs kkovaacs added this to the P2P sync milestone Jul 15, 2024
@CHr15F0x
Copy link
Member Author

CHr15F0x commented Sep 2, 2024

duplicate of #1762

@CHr15F0x CHr15F0x closed this as not planned Won't fix, can't repro, duplicate, stale Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
pathfinder
Status: Done
Milestone
P2P sync
Development

No branches or pull requests
2 participants
@kkovaacs @CHr15F0x