refactor(config): consolidate endpoint configs in runtime

Author: unenglishable

config/dev.exs

@@ -1,21 +1,5 @@
 import Config
 
-# For development, we disable any cache and enable
-# debugging and code reloading.
-#
-# The watchers configuration can be used to run external
-# watchers to your application. For example, we use it
-# with esbuild to bundle .js and .css sources.
-config :epochtalk_server, EpochtalkServerWeb.Endpoint,
-  # Binding to loopback ipv4 address prevents access from other machines.
-  # Change to `ip: {0, 0, 0, 0}` to allow access from other machines.
-  http: [ip: {0, 0, 0, 0, 0, 0, 0, 0}, port: 4000],
-  check_origin: false,
-  code_reloader: true,
-  debug_errors: false,
-  secret_key_base: "9ORa6oGSN+xlXNedSn0gIKVc/6//naQqSiZsRJ8vNbcvHpPOTPMLgcn134WIH3Pd",
-  watchers: []
-
 # For Development `config/dev.exs` loads the "Local" adapter which allows preview
 # of sent emails at the url `/dev/mailbox`. To test SMTP in Development mode,
 # mailer configurations for adapter, credentials and other options can be

config/runtime.exs

@@ -267,33 +267,76 @@ if System.get_env("IMAGES_MODE") == "S3" do
     path: System.get_env("S3_PATH", "images/")
 end
 
-if config_env() == :prod do
-  # The secret key base is used to sign/encrypt cookies and other secrets.
-  # A default value is used in config/dev.exs and config/test.exs but you
-  # want to use a different value for prod and you most likely don't want
-  # to check this value into version control, so we use an environment
-  # variable instead.
-  secret_key_base =
-    get_env_or_raise_with_message.(
-      "SECRET_KEY_BASE",
-      "You can generate one by calling: mix phx.gen.secret"
-    )
-
-  host = get_env_or_raise.("PHX_HOST")
-  port = get_env_cast_integer_with_default.("PORT", "4000")
-
-  config :epochtalk_server, EpochtalkServerWeb.Endpoint,
-    url: [host: host, port: 443, scheme: "https"],
-    http: [
-      # Enable IPv6 and bind on all interfaces.
-      # Set it to  {0, 0, 0, 0, 0, 0, 0, 1} for local network only access.
-      # See the documentation on https://hexdocs.pm/plug_cowboy/Plug.Cowboy.html
-      # for details about using IPv6 vs IPv4 and loopback vs public addresses.
-      ip: {0, 0, 0, 0, 0, 0, 0, 0},
-      port: port
-    ],
-    secret_key_base: secret_key_base
+## Configure endpoint
+base_endpoint_config = [
+  url: [host: "localhost"],
+  render_errors: [
+    formats: [json: EpochtalkServerWeb.Controllers.ErrorJSON],
+    layout: false
+  ],
+  pubsub_server: EpochtalkServer.PubSub,
+  live_view: [signing_salt: "2Ay27BWv"],
+  secret_key_base: get_env_or_raise_with_message.(
+    "SECRET_KEY_BASE",
+    """
+    You can generate one by calling: mix phx.gen.secret
+    If running in dev mode, add it to .env
+    """
+  )
+]
+# Secret key base is used to sign/encrypt cookies and other secrets.
+endpoint_secret_key_base =
+
+endpoint_config = case config_env() do
+  :dev ->
+    # For development, we disable any cache and enable
+    # debugging and code reloading.
+    #
+    # The watchers configuration can be used to run external
+    # watchers to your application. For example, we use it
+    # with esbuild to bundle .js and .css sources.
+    [
+      # Binding to loopback ipv4 address prevents access from other machines.
+      # Change to `ip: {0, 0, 0, 0}` to allow access from other machines.
+      http: [ip: {0, 0, 0, 0, 0, 0, 0, 0}, port: 4000],
+      check_origin: false,
+      code_reloader: true,
+      debug_errors: false,
+      watchers: []
+    ]
+  :test ->
+    # We don't run a server during test. If one is required,
+    # you can enable the server option below.
+    [
+      http: [ip: {127, 0, 0, 1}, port: 4002],
+      server: false
+    ]
+  :prod ->
+    host = get_env_or_raise.("PHX_HOST")
+    port = get_env_cast_integer_with_default.("PORT", "4000")
+    [
+      # Include the path to a cache manifest
+      # containing the digested version of static files. This
+      # manifest is generated by the `mix phx.digest` task,
+      # which you should run after static files are built and
+      # before starting your production server.
+      cache_static_manifest: "priv/static/cache_manifest.json",
+      url: [host: host, port: 443, scheme: "https"],
+      http: [
+        # Enable IPv6 and bind on all interfaces.
+        # Set it to  {0, 0, 0, 0, 0, 0, 0, 1} for local network only access.
+        # See the documentation on https://hexdocs.pm/plug_cowboy/Plug.Cowboy.html
+        # for details about using IPv6 vs IPv4 and loopback vs public addresses.
+        ip: {0, 0, 0, 0, 0, 0, 0, 0},
+        port: port
+      ]
+    ]
+end
+
+config :epochtalk_server, EpochtalkServerWeb.Endpoint,
+  Keyword.merge(base_endpoint_config, endpoint_config)
 
+if config_env() == :prod do
   # ## Configuring the mailer
   #
   # In production you need to configure the mailer to use a different adapter.

config/test.exs

@@ -1,12 +1,5 @@
 import Config
 
-# We don't run a server during test. If one is required,
-# you can enable the server option below.
-config :epochtalk_server, EpochtalkServerWeb.Endpoint,
-  http: [ip: {127, 0, 0, 1}, port: 4002],
-  secret_key_base: "sFacLki12NmjBfy3rJHugf+w+o36b07r99JfjcDAliabs3JdmQ4GAJKlgPVvaaah",
-  server: false
-
 # In test we don't send emails.
 config :epochtalk_server, EpochtalkServer.Mailer, adapter: Swoosh.Adapters.Test
 

example.env

@@ -3,3 +3,4 @@ AWS_SECRET_ACCESS_KEY=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
 AWS_REGION=us-west-2
 IMAGES_MODE=S3
 S3_BUCKET=xxxxxxxxxxxxx
+SECRET_KEY_BASE=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx