Skip to content

Reduce the size of the npm package by limiting the included files #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paazmaya opened this issue Oct 31, 2018 · 4 comments · May be fixed by #4
Open

Reduce the size of the npm package by limiting the included files #2

paazmaya opened this issue Oct 31, 2018 · 4 comments · May be fixed by #4

Comments

@paazmaya
Copy link

Looks like the files property (https://docs.npmjs.com/files/package.json#files) is not used in package.json to specify the included files, nor is the .npmignore file (https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package) is being used for blacklisting unwanted files, for the package published to npm.

Would you consider adding either the files property or the .npmignore file, so that the resulting package file would have smaller size?

The current size can be seen when executing the command npm pack (https://docs.npmjs.com/cli/pack).

This issue was create via tawata

@knksmith57
Copy link

for reference:

❯ npm view fast-json-stable-stringify dist.tarball | xargs curl -sS | tar -tz
package/package.json
package/.npmignore
package/README.md
package/LICENSE
package/index.js
package/.travis.yml
package/.eslintrc.yml
package/benchmark/index.js
package/benchmark/test.json
package/example/key_cmp.js
package/example/nested.js
package/example/str.js
package/example/value_cmp.js
package/test/cmp.js
package/test/nested.js
package/test/str.js
package/test/to-json.js

@epoberezkin
Copy link
Owner

Files property is ok

knksmith57 added a commit to knksmith57/fast-json-stable-stringify that referenced this issue Jan 6, 2019
@knksmith57
Copy link

just touching base, @epoberezkin, to let you know that I worked a small PR to address these concerns: #4.

please let me know if there's anything else I can do! thanks!

@JackHowa
Copy link

JackHowa commented Jul 6, 2023

curious about this @epoberezkin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants