Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning when the length of delays are longer than the supplied data #739

Open
seabbs opened this issue Aug 7, 2024 · 4 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@seabbs
Copy link
Contributor

seabbs commented Aug 7, 2024

Some users may accidentally supply PMFs that are longer than the observed data (or intentionally in some rare settings). In theory this should be handled internally by slicing them to match the maximum length but in practice (i.e. #735) this may lead to issues. Even if this is working as intended we likely want to warn the users that this is happening vs doing it automatically.

We likely want to make this warning once per session so as not to annoy advanced users who want this functionality.

@seabbs
Copy link
Contributor Author

seabbs commented Oct 8, 2024

This is resolved right?

@jamesmbaazam
Copy link
Contributor

Not that I'm aware of. I fixed the other one though (#738).

@sbfnk
Copy link
Contributor

sbfnk commented Nov 12, 2024

Do we really want this? I can see that this was a problem in the case of #735 but that's been resolved. In the more general case I would think what the user believes about a certain delay (and what its max should be) is independent of the data.

@seabbs
Copy link
Contributor Author

seabbs commented Nov 12, 2024

I just don't really like things happening automatically under the hood that users may not be aware of. It also seems to have led to a lot of issues for users (nearly all recent issues we have had I think)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants