New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove legacy TokenTrie #67

Open

Saibo-creator opened this issue Jul 6, 2024 · 0 comments

Collaborator

Saibo-creator commented Jul 6, 2024

Currently there is ByteTrie at https://github.com/epfl-dlab/transformers-CFG/blob/main/transformers_cfg/tokenization/trie.py#L21
and also a TokenTrie at https://github.com/epfl-dlab/transformers-CFG/blob/main/transformers_cfg/tokenization/vocab_struct.py#L13

TokenTrie is the legacy code from previous implementation and it should be completely removed and replaced by ByteTrie.

There is still dependency on it in the parsing, so may need to treat it carefully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment