Skip to content

Commit eef5e6d

Browse files
committed
mobile/deps: Bump rules_android -> 0.6.0
Signed-off-by: Ryan Northey <[email protected]>
1 parent 9d95690 commit eef5e6d

File tree

5 files changed

+27
-4
lines changed

5 files changed

+27
-4
lines changed

mobile/.bazelrc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,9 @@ build --define=envoy_full_protos=disabled
3535
build --define envoy_exceptions=disabled
3636
build: --copt=-fno-exceptions
3737

38+
build: --experimental_enable_android_migration_apis
39+
build: --experimental_google_legacy_api
40+
3841
# We don't have a ton of Swift in Envoy Mobile, so always build with WMO
3942
# This also helps work around a bug in rules_swift: https://github.com/bazelbuild/rules_swift/issues/949
4043
build --swiftcopt=-wmo

mobile/WORKSPACE

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,12 @@ load("@envoy//bazel:dependency_imports.bzl", "envoy_dependency_imports")
6666

6767
envoy_dependency_imports()
6868

69+
##### rules_jvm_external setup for rules_android #####
70+
load("@rules_jvm_external//:repositories.bzl", "rules_jvm_external_deps")
71+
rules_jvm_external_deps()
72+
load("@rules_jvm_external//:setup.bzl", "rules_jvm_external_setup")
73+
rules_jvm_external_setup()
74+
6975
load("@envoy_mobile//bazel:envoy_mobile_dependencies.bzl", "envoy_mobile_dependencies")
7076

7177
envoy_mobile_dependencies()
@@ -74,6 +80,9 @@ load("@envoy_mobile//bazel:envoy_mobile_toolchains.bzl", "envoy_mobile_toolchain
7480

7581
envoy_mobile_toolchains()
7682

83+
load("@rules_android//:defs.bzl", "rules_android_workspace")
84+
rules_android_workspace()
85+
7786
load("//bazel:android_configure.bzl", "android_configure")
7887

7988
android_configure(
@@ -87,6 +96,11 @@ load("@local_config_android//:android_configure.bzl", "android_workspace")
8796

8897
android_workspace()
8998

99+
register_toolchains(
100+
"@rules_android//toolchains/android:android_default_toolchain",
101+
"@rules_android//toolchains/android_sdk:android_sdk_tools",
102+
)
103+
90104
load("@com_github_buildbuddy_io_rules_xcodeproj//xcodeproj:repositories.bzl", "xcodeproj_rules_dependencies")
91105

92106
xcodeproj_rules_dependencies()

mobile/bazel/android_configure.bzl

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,13 @@ def _android_autoconf_impl(repository_ctx):
2020
sdk_rule = ""
2121
if sdk_home:
2222
sdk_rule = """
23-
native.android_sdk_repository(
23+
android_sdk_repository(
2424
name="androidsdk",
2525
path="{}",
2626
api_level={},
2727
build_tools_version="{}",
2828
)
29+
native.register_toolchains("@androidsdk//:sdk-toolchain", "@androidsdk//:all")
2930
""".format(sdk_home, sdk_api_level, build_tools_version)
3031

3132
ndk_rule = ""
@@ -46,9 +47,12 @@ def _android_autoconf_impl(repository_ctx):
4647
repository_ctx.file("BUILD.bazel", "")
4748
repository_ctx.file("android_configure.bzl", """
4849
load("@rules_android_ndk//:rules.bzl", "android_ndk_repository")
50+
load("@rules_android//rules:rules.bzl", "android_sdk_repository")
4951
5052
def android_workspace():
53+
print("SDK SETUP")
5154
{}
55+
print("NDK SETUP")
5256
{}
5357
""".format(sdk_rule, ndk_rule))
5458

mobile/bazel/envoy_mobile_dependencies.bzl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ load("@build_bazel_rules_apple//apple:repositories.bzl", "apple_rules_dependenci
33
load("@build_bazel_rules_swift//swift:repositories.bzl", "swift_rules_dependencies")
44
load("@io_bazel_rules_kotlin//kotlin:repositories.bzl", "kotlin_repositories")
55
load("@robolectric//bazel:robolectric.bzl", "robolectric_repositories")
6+
load("@rules_android//:prereqs.bzl", "rules_android_prereqs")
67
load("@rules_detekt//detekt:dependencies.bzl", "rules_detekt_dependencies")
78
load("@rules_java//java:repositories.bzl", "rules_java_dependencies")
89
load("@rules_jvm_external//:defs.bzl", "maven_install")
@@ -50,6 +51,7 @@ def envoy_mobile_dependencies(extra_maven_dependencies = []):
5051

5152
swift_dependencies()
5253
kotlin_dependencies(extra_maven_dependencies)
54+
rules_android_prereqs()
5355

5456
def swift_dependencies():
5557
apple_support_dependencies()

mobile/bazel/envoy_mobile_repositories.bzl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,9 @@ def kotlin_repos():
9797
def android_repos():
9898
http_archive(
9999
name = "rules_android",
100-
urls = ["https://github.com/bazelbuild/rules_android/archive/refs/tags/v0.1.1.zip"],
101-
sha256 = "cd06d15dd8bb59926e4d65f9003bfc20f9da4b2519985c27e190cddc8b7a7806",
102-
strip_prefix = "rules_android-0.1.1",
100+
urls = ["https://github.com/bazelbuild/rules_android/archive/refs/tags/v0.6.0.zip"],
101+
sha256 = "691c90615ebf66aa474fdd5e17b92d54f62e5e3627f4eb224e9321cfcf5fe83f",
102+
strip_prefix = "rules_android-0.6.0",
103103
)
104104
http_archive(
105105
name = "rules_android_ndk",

0 commit comments

Comments
 (0)