-
-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mob][preview] add support for video streaming #4253
base: main
Are you sure you want to change the base?
Conversation
…into mobile-preview-video
…w video components
…into mobile-preview-video
Hi @prateekmedia , I have built and tried this branch. I am not sure yet what to expect from the feature itself but what I have noticed is that some videos are rotated (while keeping the original dimension). A portrait video is played in portrait mode but the video is rotated 90° and fitted to the screen. Any way I can help testing the feature itself? I do see some changes but, for example, when trying to read a 2GB remote video (which is not on my phone), then it seems like it is first downloading the full video first. Also I am not sure what should the "cache preview" option do? Tested on Pixel 6a. |
Hi @simondubrulle , This PR is just for the mobile end. The backend is done separate on video_file_preview branch. Regarding the rotation part, it was due to the source of video_player, I have reverted it to original. Also regarding the "Cache Preview", it will work only when you spin up the local backend using the said branch. |
Great, I see, thank you. It seems the last commit is not yet solving the rotation issue. |
Description