Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auth] 8 new provider icons #4177

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[auth] 8 new provider icons #4177

wants to merge 4 commits into from

Conversation

mfkp
Copy link

@mfkp mfkp commented Nov 26, 2024

Add icons for AWS, DigitalOcean, Dropbox, Front, QNAP, Rocket Money, Slack, and WordPress

@CLAassistant
Copy link

CLAassistant commented Nov 26, 2024

CLA assistant check
All committers have signed the CLA.

@ua741
Copy link
Member

ua741 commented Nov 28, 2024

@mfkp Thank you for the PR. Going forward, we are only planning to use lower_case in the icon filename. Can you please update your PR, and may be doc as well?

@mfkp
Copy link
Author

mfkp commented Nov 28, 2024

Sure, will update. Just to clarify, with an example filename of "wordpress.svg", will "WordPress" title match automatically or is it case sensitive and I'll need to provide the slug?

@ua741
Copy link
Member

ua741 commented Dec 2, 2024

Sure, will update. Just to clarify, with an example filename of "wordpress.svg", will "WordPress" title match automatically or is it case sensitive and I'll need to provide the slug?

Wordpress should work fine. Sorry for the delay in responding.

@ua741 ua741 changed the title 8 new provider icons [auth] 8 new provider icons Dec 2, 2024
@mfkp
Copy link
Author

mfkp commented Dec 2, 2024

@ua741 updated the icon names and the corresponding guide for adding icons 👍

Looks like you merged in a dropbox icon while this one was pending though, so will need to resolve that merge.
Edit: resolved the merge issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants