Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with date when renewing #903

Open
eatdostacos opened this issue Oct 27, 2024 · 0 comments
Open

Issue with date when renewing #903

eatdostacos opened this issue Oct 27, 2024 · 0 comments

Comments

@eatdostacos
Copy link

When renewing an ENS name, I ran across an issue with the date on the "Confirm Details" screen (as shown below).
image
The date shown is x years from the current date, not from the date that the domain actually expires. For example, the domain being renewed in the screenshot above expires in 2026, yet it displays 2 years from today for the updated renewal date. This is all correct once renewed, just an issue with the frontend display. I believe I located the issue in the file /src/components/@molecules/TransactionDialogManager/DisplayItems.tsx in the DurationValue function. It seems to have been introduced with #872.

Currently, on line 245, the date is set to the current date, and then on lines 247 and 248 the numbers of months and years are added to the current date, not the date that the domain is supposed to expire. This also ignores the day of the month, as, for example, setting the renewal to May 1 or May 31 results in the same display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant