Skip to content

Commit 7f0f475

Browse files
auvipymgaligniana
authored andcommitted
Update docs/api-guide/testing.md
1 parent 98ca6a3 commit 7f0f475

File tree

2 files changed

+17
-14
lines changed

2 files changed

+17
-14
lines changed

docs/api-guide/testing.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -105,19 +105,19 @@ This means that setting attributes directly on the request object may not always
105105
request.user = user
106106
response = view(request)
107107

108-
In case you want to test the request having a REST famework's `Request` you have to transform it by-hand before:
108+
If you want to test a request involving the REST framework’s 'Request' object, you’ll need to manually transform it first:
109109

110110
class DummyView(APIView):
111111
...
112112

113113
factory = APIRequestFactory()
114114
request = factory.get('/', {'demo': 'test'})
115-
DRF_request = DummyView().initialize_request(request)
116-
assert DRF_request.query_params == {'demo': ['test']}
115+
drf_request = DummyView().initialize_request(request)
116+
assert drf_request.query_params == {'demo': ['test']}
117117

118118
request = factory.post('/', {'example': 'test'})
119-
DRF_request = DummyView().initialize_request(request)
120-
assert DRF_request.data.get('example') == 'test'
119+
drf_request = DummyView().initialize_request(request)
120+
assert drf_request.data.get('example') == 'test'
121121

122122
---
123123

tests/test_testing.py

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
from rest_framework.test import (
1818
APIClient, APIRequestFactory, URLPatternsTestCase, force_authenticate
1919
)
20+
from rest_framework.views import APIView
2021

2122

2223
@api_view(['GET', 'POST', 'PUT', 'PATCH', 'DELETE', 'OPTIONS'])
@@ -295,24 +296,26 @@ def test_explicitly_enforce_csrf_checks(self):
295296
assert response.data == expected
296297

297298
def test_transform_factory_django_request_to_drf_request(self):
298-
from rest_framework.views import APIView
299+
"""
300+
ref: GH-3608 & GH-4440.
301+
"""
299302

300303
factory = APIRequestFactory()
301304

302-
class DummyView(APIView):
305+
class DummyView(APIView): # Your custom view.
303306
...
304307

305308
request = factory.get('/', {'demo': 'test'})
306-
DRF_request = DummyView().initialize_request(request)
307-
assert DRF_request.query_params == {'demo': ['test']}
308-
assert not hasattr(DRF_request, 'accepted_media_type')
309+
drf_request = DummyView().initialize_request(request)
310+
assert drf_request.query_params == {'demo': ['test']}
311+
assert hasattr(drf_request, 'accepted_media_type') is False
309312

310-
DummyView().initial(DRF_request)
311-
assert DRF_request.accepted_media_type == 'application/json'
313+
DummyView().initial(drf_request)
314+
assert drf_request.accepted_media_type == 'application/json'
312315

313316
request = factory.post('/', {'example': 'test'})
314-
DRF_request = DummyView().initialize_request(request)
315-
assert DRF_request.data.get('example') == 'test'
317+
drf_request = DummyView().initialize_request(request)
318+
assert drf_request.data.get('example') == 'test'
316319

317320
def test_invalid_format(self):
318321
"""

0 commit comments

Comments
 (0)