Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undo useState changes #10

Open
emalinegayhart opened this issue Jan 19, 2023 · 1 comment
Open

undo useState changes #10

emalinegayhart opened this issue Jan 19, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@emalinegayhart
Copy link
Member

emalinegayhart commented Jan 19, 2023

useState seemed to be overriding placeholder value, and without a placeholder value, the boxes shrink on mobile to different sizes dependent on device. (see pic)

My bad fix: I changed useState defaults to what I wanted to use for placeholders.

What it did: This affected the range of time accepted for event input (should be only 1 hr in future to 7 days in future, but now accepts anything).

My conclusion: Placeholder values will not work with useState & useState should not be used to display placeholder values.

Quick fix: Must find way to keep input boxes open without placeholder value (possibly max width of input field?)

Ideal fix: Shouldn't useState be able to set placeholder values and not affect input accepted? Input accepted should be determined by schema & zod validation, and unaffected by what's displaying in the box by useState.

Note: Need to look to make sure changes weren't made to input validation.

image

@emalinegayhart
Copy link
Member Author

undid changes, still need to find fix to keep input boxes open on mobile when values are cleared

@emalinegayhart emalinegayhart added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant