Skip to content

Commit 3dd4889

Browse files
authored
[jsifier] Extract isAlias helper function. NFC (#25920)
1 parent 9e9fddc commit 3dd4889

File tree

1 file changed

+20
-20
lines changed

1 file changed

+20
-20
lines changed

src/jsifier.mjs

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,14 @@ function isDefined(symName) {
128128
return false;
129129
}
130130

131+
function isAlias(snippet) {
132+
return (typeof snippet == 'string' && snippet[0] != '=' && (LibraryManager.library.hasOwnProperty(snippet) || WASM_EXPORTS.has(snippet)));
133+
}
134+
131135
function resolveAlias(symbol) {
132136
while (true) {
133137
var value = LibraryManager.library[symbol];
134-
if (typeof value == 'string' && value[0] != '=' && (LibraryManager.library.hasOwnProperty(value) || WASM_EXPORTS.has(value))) {
138+
if (isAlias(value)) {
135139
symbol = value;
136140
} else {
137141
break;
@@ -652,25 +656,21 @@ function(${args}) {
652656
}
653657
}
654658

655-
if (typeof snippet == 'string') {
656-
if (snippet[0] != '=') {
657-
if (LibraryManager.library[snippet] || WASM_EXPORTS.has(snippet)) {
658-
// Redirection for aliases. We include the parent, and at runtime
659-
// make ourselves equal to it. This avoid having duplicate
660-
// functions with identical content.
661-
const aliasTarget = resolveAlias(snippet);
662-
if (WASM_EXPORTS.has(aliasTarget)) {
663-
//printErr(`native alias: ${mangled} -> ${snippet}`);
664-
//console.error(WASM_EXPORTS);
665-
nativeAliases[mangled] = aliasTarget;
666-
snippet = undefined;
667-
isNativeAlias = true;
668-
} else {
669-
//printErr(`js alias: ${mangled} -> ${snippet}`);
670-
deps.push(aliasTarget);
671-
snippet = mangleCSymbolName(aliasTarget);
672-
}
673-
}
659+
if (isAlias(snippet)) {
660+
// Redirection for aliases. We include the parent, and at runtime
661+
// make ourselves equal to it. This avoid having duplicate
662+
// functions with identical content.
663+
const aliasTarget = resolveAlias(snippet);
664+
if (WASM_EXPORTS.has(aliasTarget)) {
665+
//printErr(`native alias: ${mangled} -> ${snippet}`);
666+
//console.error(WASM_EXPORTS);
667+
nativeAliases[mangled] = aliasTarget;
668+
snippet = undefined;
669+
isNativeAlias = true;
670+
} else {
671+
//printErr(`js alias: ${mangled} -> ${snippet}`);
672+
deps.push(aliasTarget);
673+
snippet = mangleCSymbolName(aliasTarget);
674674
}
675675
} else if (typeof snippet == 'object') {
676676
snippet = stringifyWithFunctions(snippet);

0 commit comments

Comments
 (0)