WasmFS JS API: Update rmdir (#19532)

This PR updates FS.rmdir to throw errors, as per the new convention.

Author: jameshu15869

src/library_wasmfs.js

@@ -115,10 +115,7 @@ FS.createPreloadedFile = FS_createPreloadedFile;
     },
     // TODO: mkdirTree
     rmdir: (path) => {
-      return withStackSave(() => {
-        var buffer = stringToUTF8OnStack(path);
-        return __wasmfs_rmdir(buffer);
-      })
+      return FS.handleError(withStackSave(() => __wasmfs_rmdir(stringToUTF8OnStack(path))));
     },
     open: (path, flags, mode) => {
       flags = typeof flags == 'string' ? FS_modeStringToFlags(flags) : flags;

test/fs/test_dir.c

@@ -111,6 +111,58 @@ int main() {
         assert(ex.name === 'ErrnoError' && ex.errno == 8 /* EBADF */);
     );
 
+    /********** test FS.rmdir() **********/
+    EM_ASM(
+        // Create multiple directories
+        FS.mkdir('/dir1');
+        FS.mkdir('/dir2');
+    );
+
+    struct stat s;
+    stat("/dir1", &s);
+    assert(S_ISDIR(s.st_mode));
+    stat("/dir2", &s);
+    assert(S_ISDIR(s.st_mode));
+
+
+    EM_ASM(
+        // Remove the multiple directories
+        FS.rmdir('/dir1');
+        FS.rmdir('/dir2');
+    );
+
+    int err = open("/dir1", O_RDWR);
+    assert(err);
+    err = open("/dir2", O_RDWR);
+    assert(err);
+
+    EM_ASM(    
+        // Create a directory with a file inside it
+        FS.mkdir('/test_dir');
+        FS.writeFile('/test_dir/file.txt', 'Hello World!');
+
+        // Attempt to remove the directory (should fail)
+        var ex;
+        try {
+        FS.rmdir('/test_dir');
+        } catch (err) {
+        ex = err;
+        }
+        assert(ex.name === "ErrnoError" && ex.errno === 55 /* ENOTEMPTY */);
+
+        // Remove the file and then the directory
+        FS.unlink('/test_dir/file.txt');
+        FS.rmdir('/test_dir');
+
+        // Attempt to remove a non-existent directory (should fail)
+        try {
+        FS.rmdir('/non_existent_dir');
+        } catch (err) {
+        ex = err;
+        }
+        assert(ex.name === "ErrnoError" && ex.errno === 44 /* ENOEN */);
+    );
+
     /********** test FS.close() **********/
     EM_ASM(
         FS.writeFile("closetestfile", 'a=1\nb=2\n');

test/fs/test_fs_js_api.c

@@ -5951,11 +5951,6 @@ def test_istream(self):
       self.set_setting('LINKABLE', linkable)
       self.do_core_test('test_istream.cpp')
 
-  def test_fs_dir_wasmfs(self):
-    self.emcc_args += ['-sWASMFS']
-    self.emcc_args += ['-sFORCE_FILESYSTEM']
-    self.do_runf(test_file('fs/test_dir.c'), 'success')
-
   def test_fs_base(self):
     self.set_setting('DEFAULT_LIBRARY_FUNCS_TO_INCLUDE', ['$FS'])
     self.uses_es6 = True