changes on comment lines

Author: emrekasg

aof.go

@@ -41,13 +41,19 @@ type AOF struct {
 	aofChan   chan *AofCmd
 	Options   *AOFOptions
 	listeners map[Listener]struct{}
-	buffer    []CmdLine
+	buffer    [][][]byte
 	segment   *os.File
 	segments  []*segment
 
 	reader *Reader
 }
 
+type AofCmd struct {
+	CmdLine [][]byte
+	DbIndex int
+	Wg      *sync.WaitGroup
+}
+
 func NewAOF(aofOptions *AOFOptions) (*AOF, error) {
 	var err error
 
@@ -74,15 +80,14 @@ func NewAOF(aofOptions *AOFOptions) (*AOF, error) {
 		return nil, err
 	}
 
-	// schedule fsync every 1 second to avoid data loss
 	go func() {
 		for {
 			select {
 			case <-aof.ctx.Done():
 				return
 			default:
 				if FsyncEverySecond == aof.Options.Fsync {
-					aof.fsync()
+					aof.fsync() // fsync every second
 				}
 				aof.Retention()
 				time.Sleep(time.Second * 1)
@@ -95,7 +100,7 @@ func NewAOF(aofOptions *AOFOptions) (*AOF, error) {
 }
 
 // WriteAof writes a new entry to the Append-Only Log.
-func (aof *AOF) WriteAof(p *AofCmd) {
+func (aof *AOF) WriteAof(p *AofCmd) error {
 	aof.sync.Lock()
 	defer aof.sync.Unlock()
 	aof.buffer = aof.buffer[:0] // clear the buffer
@@ -107,7 +112,7 @@ func (aof *AOF) WriteAof(p *AofCmd) {
 
 	// write to aof file in byte format
 	if _, err := aof.segment.Write(bufferInBytes); err != nil {
-		panic(err) // TODO: use a logger
+		return err
 	}
 
 	if FsyncAlways == aof.Options.Fsync {
@@ -118,6 +123,8 @@ func (aof *AOF) WriteAof(p *AofCmd) {
 	for listener := range aof.listeners {
 		listener.Callback(aof.buffer)
 	}
+
+	return nil
 }
 
 // bufferToBytes converts the buffer to bytes and adds a file header.

cmd.go

@@ -18,9 +18,7 @@ func (aof *AOF) fsync() {
 	aof.sync.Lock()
 	defer aof.sync.Unlock()
 
-	if err := aof.segment.Sync(); err != nil {
-		panic(err) // TODO: use a logger
-	}
+	aof.segment.Sync()
 }
 
 func (aof *AOF) loadFiles() error {

file.go

@@ -1,9 +1,8 @@
 package aof
 
-// Listener going to run after aofChan receive a command
-// and before the command is written to the aof file
+// Listener  uns after aofChan receive a command
 type Listener interface {
-	Callback([]CmdLine)
+	Callback([][][]byte)
 }
 
 func (aof *AOF) AddListener(listener Listener) {

listener.go

@@ -1,7 +1,7 @@
 package aof
 
-// we need retention to be able to check if size of the aof file is greater than 20MB
-// if it is, we need to create a new segment and write to it
+// Checks if the segment file is greater than the maximum size.
+// If it is, then create a new segment file and close the current one.
 func (aof *AOF) Retention() error {
 	stat, err := aof.segment.Stat()
 	if err != nil {