Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply ngen to installer #653

Closed
MagicAndre1981 opened this issue Nov 22, 2024 · 8 comments
Closed

Apply ngen to installer #653

MagicAndre1981 opened this issue Nov 22, 2024 · 8 comments

Comments

@MagicAndre1981
Copy link

It would be nice if you could ngen MonitorianPlus.exe after setup to improve performance.

@emoacht
Copy link
Owner

emoacht commented Nov 24, 2024

Microsoft Store version does not use WiX.
And in most times, this app waits for the response from external monitors. If you feel this app is slow, it means that your monitors are slow.

@MagicAndre1981
Copy link
Author

it is not really slow for me, but I want all .net apps to be ngened . Maybe update to .net9 and use AOT 🤔

@emoacht
Copy link
Owner

emoacht commented Nov 24, 2024

If migrated to .NET, the download size of this app will become a hundred times bigger (this is not an exaggeration).
Since the practical benefit from the migration would be negligible, there is no compelling reason for it.

@emoacht emoacht changed the title Enhancement: ngen MonitorianPlus.exe after setup Apply ngen to installer Nov 24, 2024
@emoacht emoacht closed this as completed Nov 24, 2024
@emoacht
Copy link
Owner

emoacht commented Nov 24, 2024

Applied NGen to installer of standard version by 6dc4152

@MagicAndre1981
Copy link
Author

thanks. Got the update installed with winget and yes the exe is ngened during setup 👍

@emoacht
Copy link
Owner

emoacht commented Dec 31, 2024

To be clear, the version which is installed by winget is Microsoft Store version.

@MagicAndre1981
Copy link
Author

no, it is the normal installer version and I saw that ngen was called from msiexec.exe

@emoacht
Copy link
Owner

emoacht commented Dec 31, 2024

I see. I have not noticed that. It is not under my control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants