Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that app shell isn't correctly cached by the service worker. Consequently PWA doesn't start correctly.
Steps to reproduce
trunk serve
Proposed solution
eframe_template-*
. This makes paths insw.js
underfilesToCache
invalid. I solved it by addingfilehash = false
. The other option could be generatingsw.js
with correct filenames inpost_build
hook of trunkrs.manifest.json
is served fromassets/
, then installed PWA starts from attempting to readassets/index.html
from cache. The file is non-existing, so startup fails. I solved it by movingmanifest.json
to the root directory. This required relative paths inmanifest.json
to be updated.