Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contradiction regarding rust version? #110

Open
c-git opened this issue Oct 5, 2023 · 6 comments · May be fixed by #176
Open

Contradiction regarding rust version? #110

c-git opened this issue Oct 5, 2023 · 6 comments · May be fixed by #176

Comments

@c-git
Copy link
Contributor

c-git commented Oct 5, 2023

In the Testing Locally section of the readme, it says

Make sure you are using the latest version of stable rust by running rustup update

but the repo also includes a toolchain file. Wouldn't that mean that running rustup update wouldn't matter?

@gcp
Copy link

gcp commented Feb 19, 2024

There's a similar oddity in that rust.yml uses toolchain: stable everywhere except: https://github.com/emilk/eframe_template/blob/master/.github/workflows/rust.yml#L99

@c-git
Copy link
Contributor Author

c-git commented Feb 20, 2024

I feel these are likely just oversights not sure what's the best way to address them as I think they are already a bit overloaded with PRs

@mowdl
Copy link

mowdl commented Apr 8, 2024

For me, running cargo install --locked trunk would not work inside the project folder because trunk needs a newer version of rust.

So I think you need the latest version to install trunk but to compile the app you use the version specified by the rust-toolchain file.

@YertleTurtleGit
Copy link

YertleTurtleGit commented Apr 13, 2024

I'm facing the same confusion. I was also wondering if this causes my IDE (VS Codium) to not properly initialize the rust-analyzer:

cargo check failed to start: Cargo watcher failed, the command produced no valid metadata (exit code: ExitStatus(unix_wait_status(256))):

error: 'cargo-clippy' is not installed for the custom toolchain '/home/user/.rustup/toolchains/1.72.0-x86_64-unknown-linux-gnu'.

note: this is a custom toolchain, which cannot use `rustup component add`

help: if you built this toolchain from source, and used `rustup toolchain link`, then you may be able to build the component with `x.py`

Any ideas about how to solve this or if this is even related?

@c-git
Copy link
Contributor Author

c-git commented Apr 14, 2024

Yes that problem is caused by using the different version of rust. Just remove the rust-toolchain file and you should be good to go.

@c-git c-git linked a pull request Dec 24, 2024 that will close this issue
@c-git
Copy link
Contributor Author

c-git commented Dec 24, 2024

After having had time to think about this. I think updating the readme is the right approach because the toolchain file gets updated each release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants