feat(comments): reactions + Wilson 'Best' sort (Tier 1)#1540
Open
marcusbellamyshaw-cell wants to merge 3 commits into
Open
feat(comments): reactions + Wilson 'Best' sort (Tier 1)#1540marcusbellamyshaw-cell wants to merge 3 commits into
marcusbellamyshaw-cell wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: 9e370e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Scope checkThis PR changes 1,012 lines across 16 files. Large PRs are harder to review and more likely to be closed without review. If this scope is intentional, no action needed. A maintainer will review it. If not, please consider splitting this into smaller PRs. See CONTRIBUTING.md for contribution guidelines. |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
github-actions
Bot
added
review/needs-review
Author
|
I have read the CLA Document and I hereby sign the CLA |
marcusbellamyshaw-cell
force-pushed
the
feat/comment-reactions
branch
from
c3c773f to
69de904
Compare
Tier 1 of the best-in-class comments RFC. Visitors can react (like) to approved comments; reactions are stored first-party in a new _emdash_comment_reactions table, deduped per voter by a salted IP hash, and served via a public, honeypot- and rate-limited endpoint at GET/POST /_emdash/api/comments/:collection/:contentId/reactions. The <Comments> component gains two opt-in props: `reactions` (render a like button + live counts) and `sort="best"` (Reddit-style Wilson lower-bound ranking). Posting is progressively enhanced via a tiny inline script emitted only when reactions are enabled. Additive and backward-compatible: new table, new route, new optional props with behavior-preserving defaults. Includes a changeset and tests. AI disclosure: implemented with assistance from Claude (claude-opus-4-8); all code verified against the repository and the full test suite. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…gration The reactions endpoint (GET/POST /_emdash/api/comments/:collection/:contentId/reactions) needs an explicit injectRoute entry in injectCoreRoutes — without it the path falls through to the page handler. Verified end-to-end against the demo: toggle on/off and aggregate counts return the expected JSON. AI disclosure: implemented with assistance from Claude (claude-opus-4-8). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ucket limit Adversarial self-review follow-ups on the reactions prototype: - toggle() no longer does read-then-write. A concurrent double-toggle from the same voter could both see "no row" and have the second INSERT violate the unique index, surfacing as a 500. Now an idempotent INSERT ... ON CONFLICT DO NOTHING branches on whether a row was written, so it never throws. - handleReactionToggle rejects reactions outside an allowlist (currently just "like", matching the shipped widget) so a caller can't spam arbitrary reaction strings and bloat a comment's count map. - The public reactions route documents that the salted-IP voter hash collapses to a shared "unknown" bucket without a trusted IP (per-visitor dedup is the Tier 2 visitor-identity primitive), mirroring the comment ingest route. Adds handler-level tests (happy path, unsupported reaction, non-approved and missing comment, concurrent-toggle invariant). lint + typecheck clean; 82 comment tests pass. AI disclosure: implemented with assistance from Claude (claude-opus-4-8). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
marcusbellamyshaw-cell
force-pushed
the
feat/comment-reactions
branch
from
69de904 to
9e370e2
Compare
Contributor
Overlapping PRsThis PR modifies files that are also changed by other open PRs:
This may cause merge conflicts or duplicated work. A maintainer will coordinate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds comment reactions (positive-only "like") and a Wilson score "Best" sort to the
<Comments>component. This is Tier 1 of the best-in-class comments RFC, approved by @ascorbic._emdash_comment_reactionstable (migration044) — deduped per voter via a salted IP hash (same privacy primitive as commentip_hash)GET/POST /_emdash/api/comments/:collection/:contentId/reactions<Comments>:reactions(like button + live counts) andsort="best"(Wilson lower-bound ranking for top-level comments, replies stay chronological)reactionsis enabled — pages without reactions ship zero additional JSCloses #1497 (Tier 1)
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runmessages.pochanges except in translation PRs — a workflow extracts catalogs on merge tomain. — N/A: no admin UI strings addedAI-generated code disclosure
Screenshots / test output
Before — comments today (chronological, no reactions):
After —
<Comments reactions sort="best" />:Test output: 118 tests pass, 15 new (Wilson math, toggle/dedupe, counts, rate-limit, best-sort ordering).