Bug - Tags - "Edit Tag" interface not fully visible with large #s of locales

[kodster28]

Description

When you have a large number of locales, you cannot edit an existing tag in the UI (the boundaries of the form expand beyond the viewport of your screen).

Steps to reproduce

1. Create a few different locales.
2. Go to Admin > Taxonomies > Tags.
3. Try to edit an existing item.

Environment

• emdash: 0.15.0
• Cloudflare Workers
• MacOS and Chrome

Logs / error output

[emdashbot]

The investigation bot ran into a problem and could not complete.

A maintainer can re-trigger by removing and re-applying the bot:repro label.

_{Run: https://github.com/emdash-cms/emdash/actions/runs/26781336234}

[emdashbot]

The investigation bot reproduced this issue and pushed a candidate fix.

Root cause: packages/admin/src/components/TaxonomyManager.tsx around lines 346–471 (the TermFormDialog component's render). The Kumo <Dialog className="p-6" size="lg"> has no height cap and the <form> inside it lays out header, body and footer as a single static block. The body contains the Translations panel which renders one row per non-default locale (i18n.locales.length - 1 rows). With 15 configured locales the body alone is taller than a typical viewport, so the whole dialog grows past 100vh — measured 1229.56px against a 577px viewport — and the Cancel/Update footer is pushed off-screen. There is no max-h-* on the dialog and no overflow-y-auto on an inner body container, so the user can never scroll inside the modal to reach the action buttons. This matches the reporter's screenshot and the agent-browser repro exactly.

Other modals in this codebase that can grow with data already follow the right pattern, e.g. packages/admin/src/components/MediaPickerModal.tsx:463 (max-w-4xl max-h-[80vh] flex flex-col overflow-hidden on <Dialog> plus flex-1 overflow-y-auto min-h-0 on the scrolling body) and packages/admin/src/components/SectionPickerModal.tsx:53,91. TermFormDialog is missing the same treatment.

Fix applied: Applied the exact fix proposed by diagnose: added max-h-[90vh] flex flex-col overflow-hidden to the Kumo <Dialog> in TermFormDialog, flex flex-col min-h-0 flex-1 to the inner <form>, and flex-1 overflow-y-auto min-h-0 to the scrollable body div. This mirrors the established pattern already used by MediaPickerModal.tsx and SectionPickerModal.tsx in the same codebase.

Lint (pnpm lint:quick) and typecheck (pnpm typecheck) are clean. Format ran successfully.

The admin package's vitest suite uses @vitest/browser-playwright but Playwright browsers are not installed in this environment, so those tests could not be executed. This is an infrastructure limitation, not a regression from the change. No non-browser tests exist for this component.

Browser verification could not be re-run because the agent-browser subagent is not declared in this environment. The fix is a pure CSS/layout change following an existing, verified convention in the repo.

Try the fix (the preview release may take ~60s to publish after the bot pushes its branch -- if 404s, wait a moment and retry):

npm i https://pkg.pr.new/emdash@bot/fix-1269

Screenshots:

@kodster28 could you try this and reply here with whether it resolves the issue? A simple "yes, fixed" or "no, still broken" is enough.

Fix branch: bot/fix-1269 · Artifacts branch: bot/artifacts-1269

_{Run: https://github.com/emdash-cms/emdash/actions/runs/26784492108}

[diogoascarneiro]

Not fixed - this does not play nicely with the input elements in the modal, and overlaps with the buttons (specifically "Update") at the bottom.