Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support tag-based entity relationships across the board (guidelines, terms, etc.) #301

Open
mc-dorzo opened this issue Feb 24, 2025 · 2 comments
Assignees
Labels
enhancement New feature or request priority-high

Comments

@mc-dorzo
Copy link
Contributor

mc-dorzo commented Feb 24, 2025

Motivation

We would like to associate guidelines/variables/glossary with multiple agents. For that, we would like agents to potentially be associated with multiple tags, and guidelines/variables/glossary to be associated with multiple tags instead of singular set as today (which set today is agent_id).

Solution Proposal

  • Instead of X_set (e.g., guideline_set -> Sequence[Guideline]), we want to support tags (e.g., guideline -> Sequence[TagId] )
  • In Document classes, we should change X_set: str -> X_tags: Sequence[ObjectId]
  • Agent-specific items can still work automatically by attaching the tag agent_id:<AGENT_ID> to any entity.
  • Agent will also include tags. These tags will be used to fetch relevant items that match the agent's tags.
  • API & CLI should support add and remove tags from guideline/glossary/variable/agent

Discussion

@kichanyurd Did I miss something?

@mc-dorzo mc-dorzo added the enhancement New feature or request label Feb 24, 2025
@mc-dorzo mc-dorzo self-assigned this Feb 24, 2025
@kichanyurd
Copy link
Contributor

Looks good 👍

@kichanyurd kichanyurd changed the title [Enhancement] singular set to multiple tags [Enhancement] Support tag-based relationships across the board (guidelines, terms, etc.) Feb 24, 2025
@kichanyurd kichanyurd changed the title [Enhancement] Support tag-based relationships across the board (guidelines, terms, etc.) [Enhancement] Support tag-based entity relationships across the board (guidelines, terms, etc.) Feb 24, 2025
@mc-dorzo
Copy link
Contributor Author

FYI, this breaks our current persistence design, in which we maintain a collection of associations between tags and other classes (e.g., customers) to quickly retrieve all customers associated with a specific tag.
Is that acceptable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-high
Projects
None yet
Development

No branches or pull requests

2 participants