Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo support #777

Open
runspired opened this issue Apr 5, 2023 · 3 comments
Open

Monorepo support #777

runspired opened this issue Apr 5, 2023 · 3 comments
Labels

Comments

@runspired
Copy link

I had forgotten about this until I recently began cleaning up EmberData's root package.json and hit the issue again. This project requires re-declaring all ember-cli and ember-source deps into monorepo-root in order for it to resolve them. It needs instead to properly resolve dependencies from the workspace root.

@SergeAstapov
Copy link
Collaborator

@runspired
Copy link
Author

@SergeAstapov I'm not entirely sure which thing in this project results in the problem, but if you want to replicate on EmberData main remove ember-cli and/or ember-source from the root package.json and immediately the fastboot test app in tests/fastboot will blow up on build/test if ember-cli-fastboot-testing is still installed.

The error you get will be around bower no longer being supported, which happens because ember-cli does a version-check for bower if ember-source is not found.

I believe this indicates that there is some attempted determination of project-root for require.resolve that fails when the git root is different than the workspace root. This could well be the line you just linked to.

@SergeAstapov
Copy link
Collaborator

@runspired thank you! this will give me info to replicate problem which should lead me to the root cause of the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants