Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description of diff style is incorrect in Quick Start #2090

Open
kategengler opened this issue Jan 21, 2025 · 0 comments
Open

Description of diff style is incorrect in Quick Start #2090

kategengler opened this issue Jan 21, 2025 · 0 comments

Comments

@kategengler
Copy link
Contributor

https://guides.emberjs.com/release/getting-started/quick-start/ [here in code] (https://github.com/ember-learn/guides-source/blob/master/guides/release/getting-started/quick-start.md?plain=1#L257 ) describes the diff style:

In the rest of the code examples in this tutorial, whenever we add or remove code, we will show a "diff." The lines you need to remove have a minus sign in front of them, and the lines you should add have a plus sign. If you are using a screen reader while you go through the Guides, we recommend using Firefox and NVDA or Safari and VoiceOver for the best experience.

However, the diffs display only with colors:

Image

There are no pluses or minuses in the elements either.

I suspect this may not be accessible to those with colorblindness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant