Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ember Data relationships guide has syntax that errors in 5.x #1988

Open
kategengler opened this issue Dec 21, 2023 · 0 comments · May be fixed by #2093
Open

Ember Data relationships guide has syntax that errors in 5.x #1988

kategengler opened this issue Dec 21, 2023 · 0 comments · May be fixed by #2093
Labels
ember-data

Comments

@kategengler
Copy link
Contributor

https://guides.emberjs.com/release/models/relationships/ describes defining relationships but does not include the explicit async and inverse options that are required in 5.x after this deprecation https://deprecations.emberjs.com/ember-data/v4.x/#toc_ember-data-deprecate-non-strict-relationships
@MichalBryxi MichalBryxi mentioned this issue Feb 4, 2025
Open
MichalBryxi added a commit to MichalBryxi/guides-source that referenced this issue Feb 4, 2025
@MichalBryxi
fix: v5.0 ember-data deprecates non-strict relationships
fc4db08 
- As per [ember-data:deprecate-non-strict-relationships](https://deprecations.emberjs.com/ember-data/v4.x/#toc_ember-data-deprecate-non-strict-relationships) we should update the guides to list all relationships explicitly.
- Supports ember-learn#1988
MichalBryxi added a commit to MichalBryxi/guides-source that referenced this issue Feb 4, 2025
@MichalBryxi
fix: { async: true } -> { async: false } for v5.0 ember-data
cb6e8b7 
- Seems like we want most of the examples to be synchronous
- Supports: ember-learn#1988
@MichalBryxi MichalBryxi linked a pull request Feb 4, 2025 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ember-data
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate Non Strict Relationships MichalBryxi/guides-source
2 participants
@kategengler @MelSumner