Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the manageLabelAttribute() functionality from fieldset to the form #156

Open
notmessenger opened this issue Sep 6, 2016 · 1 comment
Open

Move the manageLabelAttribute() functionality from fieldset to the form #156

notmessenger opened this issue Sep 6, 2016 · 1 comment
Labels
architecture BREAKING CHANGE ef-form form/ef-fieldset FORMS refactor
Milestone
Forms

Comments

@notmessenger
Copy link
Member

Beyond just moving it it will require modification to the logic as well. For each <label> found without a populated for attribute find the closest (DOM-wise) labelable element with a set id that is not already assigned to a <label>'s for attribute and assign its id value to the for attribute.

Can likely schedule for 'afterRender' but find the appropriate run event queue.
@notmessenger notmessenger added this to the Forms milestone Sep 6, 2016
@notmessenger
Copy link
Member Author

The logic has already been removed from ef-fieldset but still needs to be modified and added to ef-form.

7a76525 removed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
architecture BREAKING CHANGE ef-form form/ef-fieldset FORMS refactor
Projects
None yet
Milestone
Forms
Development

No branches or pull requests
1 participant
@notmessenger