Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we want form/ef-fieldset to be involved in the display of error state in the UI #153

Open
notmessenger opened this issue Sep 4, 2016 · 0 comments

Comments

@notmessenger
Copy link
Member

Because we do not want it to be required that input/textarea elements, legends, errors, etc have to be used with fieldsets we apply the ef-error class to the element and error components themselves and not to a fieldset.

Twitter Bootstrap applies error status classes to the fieldsets though (http://v4-alpha.getbootstrap.com/components/forms/#validation) so it makes me wonder if we want to follow a similar approach. Not because Twitter Bootstrap does it but because now have seen it is it something we want to do too?

We can still apply the classes to the individual components like we do now, so they still do not need to be used with fieldsets but we could also apply ef-error to the form/ef-fieldset component similar to how ember-forge/ember-forge-ui-bootstrap4@1a741b6 did for Twitter Bootstrap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant