You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Because we do not want it to be required that input/textarea elements, legends, errors, etc have to be used with fieldsets we apply the ef-error class to the element and error components themselves and not to a fieldset.
Twitter Bootstrap applies error status classes to the fieldsets though (http://v4-alpha.getbootstrap.com/components/forms/#validation) so it makes me wonder if we want to follow a similar approach. Not because Twitter Bootstrap does it but because now have seen it is it something we want to do too?
We can still apply the classes to the individual components like we do now, so they still do not need to be used with fieldsets but we could also apply ef-error to the form/ef-fieldset component similar to how ember-forge/ember-forge-ui-bootstrap4@1a741b6 did for Twitter Bootstrap.
The text was updated successfully, but these errors were encountered:
Because we do not want it to be required that input/textarea elements, legends, errors, etc have to be used with fieldsets we apply the
ef-error
class to the element and error components themselves and not to a fieldset.Twitter Bootstrap applies error status classes to the fieldsets though (http://v4-alpha.getbootstrap.com/components/forms/#validation) so it makes me wonder if we want to follow a similar approach. Not because Twitter Bootstrap does it but because now have seen it is it something we want to do too?
We can still apply the classes to the individual components like we do now, so they still do not need to be used with fieldsets but we could also apply
ef-error
to theform/ef-fieldset
component similar to how ember-forge/ember-forge-ui-bootstrap4@1a741b6 did for Twitter Bootstrap.The text was updated successfully, but these errors were encountered: