Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packageManager option as documented in README is an upcoming feature #1055

Open
abeforgit opened this issue Jan 16, 2025 · 4 comments
Open

Comments

@abeforgit
Copy link

I was trying to use this in a pnpm project, and I was baffled as to why ember-try kept using npm for installing dependencies despite me having set packageManager: 'pnpm' in my config

After much headscratching I went to look at https://github.com/universal-ember/reactiveweb/blob/main/tests/test-app/config/ember-try.js and saw that the option was actually called usePnpm: true?

Is this intended and just a documentation mishap? Or am I missing something?

@mansona
Copy link
Member

mansona commented Jan 16, 2025

Hey @abeforgit thanks for the report 👍

I don't know if I would call this a "documentation mishap" or if it's just a timing issue 😂 Essentially that change was made as part of some upcoming work that will be released as a v4.0 version. You can follow this PR and once it's merged it will be automatically released: #1051

I'll follow up with the folks working on it to see if it's due to be released soon

@bertdeblock
Copy link
Member

bertdeblock commented Jan 16, 2025

Yeah, my bad, we should probably try to release soon, or I could also add a note to the README, saying the docs are for the upcoming v4 release. For now, usePnpm: true is still correct, but will trigger a deprecation in v4. More info here.

@abeforgit
Copy link
Author

great! thank you for the info. Can be closed for me, but might want to leave it up until that pr is merged? I'll leave it up to the maintainers

@bertdeblock
Copy link
Member

Leaving this open is good I think!

@kategengler kategengler changed the title packageManager option as documented in README doesn't work packageManager option as documented in README is an upcoming feature Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants