nodiscard

Author: NeiroYT

include/layers/ConvLayer.hpp

@@ -69,7 +69,7 @@ class ConvolutionalLayer : public Layer {
     return res;
   }
 
-  bool getLegacyImplBool() const { return useLegacyImpl_; }
+  [[nodiscard]] bool getLegacyImplBool() const { return useLegacyImpl_; }
 
   void run(const std::vector<Tensor>& input,
            std::vector<Tensor>& output) override;

test/single_layer/test_convlayer.cpp

@@ -18,9 +18,9 @@ TEST(ConvolutionalLayerTest, Getters) {
   Tensor input2 = make_tensor<float>(vec, {2, 2});
   std::vector<Tensor> in{input1, input2};
   std::vector<Tensor> output{input1};
-  EXPECT_NO_THROW(layer.getLegacyImplBool());
-  EXPECT_NO_THROW(layer.getNumericParams());
-  EXPECT_NO_THROW(layer.getTensorParams());
+  EXPECT_NO_THROW(auto ret1 = layer.getLegacyImplBool());
+  EXPECT_NO_THROW(auto ret2 = layer.getNumericParams());
+  EXPECT_NO_THROW(auto ret3 = layer.getTensorParams());
 }
 
 TEST(ConvolutionalLayerTest, IncompatibleInput) {