Skip to content

Commit 4072054

Browse files
committed
Change default of data binding properties sendValidationInfo to true
1 parent 2e91cbf commit 4072054

File tree

3 files changed

+15
-11
lines changed

3 files changed

+15
-11
lines changed

embabel-agent-api/src/main/kotlin/com/embabel/agent/core/support/AbstractLlmOperations.kt

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -75,16 +75,17 @@ abstract class AbstractLlmOperations(
7575
})
7676

7777
val (createdObject, ms) = time {
78-
val initialMessages = if (dataBindingProperties.sendValidationInfo) {
79-
messages + UserMessage(
80-
validationPromptGenerator.generateRequirementsPrompt(
81-
validator = validator,
82-
outputClass = outputClass,
78+
val initialMessages =
79+
if (validator.getConstraintsForClass(outputClass).isBeanConstrained && dataBindingProperties.sendValidationInfo) {
80+
messages + UserMessage(
81+
validationPromptGenerator.generateRequirementsPrompt(
82+
validator = validator,
83+
outputClass = outputClass,
84+
)
8385
)
84-
)
85-
} else {
86-
messages
87-
}
86+
} else {
87+
messages
88+
}
8889

8990
var candidate = doTransform(
9091
messages = initialMessages,

embabel-agent-api/src/main/kotlin/com/embabel/agent/spi/support/LlmDataBindingProperties.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ import java.time.Duration
3636
class LlmDataBindingProperties(
3737
override val maxAttempts: Int = 10,
3838
val fixedBackoffMillis: Long = 30L,
39-
val sendValidationInfo: Boolean = false,
39+
val sendValidationInfo: Boolean = true,
4040
) : RetryTemplateProvider {
4141

4242
private val logger = LoggerFactory.getLogger(LlmDataBindingProperties::class.java)

embabel-agent-api/src/test/kotlin/com/embabel/agent/spi/support/ChatClientLlmOperationsTest.kt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -748,7 +748,10 @@ class ChatClientLlmOperationsTest {
748748
)
749749
val prompt =
750750
"Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed do eiusmod tempor incididunt ut labore et dolore magna aliqua."
751-
val setup = createChatClientLlmOperations(fakeChatModel)
751+
val setup = createChatClientLlmOperations(
752+
fakeChatModel,
753+
LlmDataBindingProperties(sendValidationInfo = false)
754+
)
752755
val createdDog = setup.llmOperations.createObject(
753756
messages = listOf(UserMessage(prompt)),
754757
interaction = LlmInteraction(

0 commit comments

Comments
 (0)