style: apply melpazoid style suggestions

Author: unmonoqueteclea

.github/workflows/melpazoid.yml

@@ -0,0 +1,31 @@
+# melpazoid <https://github.com/riscy/melpazoid> build checks.
+
+# If your package is on GitHub, enable melpazoid's checks by copying this file
+# to .github/workflows/melpazoid.yml and modifying RECIPE and EXIST_OK below.
+
+name: melpazoid
+on: [push, pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v3
+    - name: Set up Python 3.10
+      uses: actions/setup-python@v4
+      with:
+        python-version: '3.10'
+    - name: Install
+      run: |
+        python -m pip install --upgrade pip
+        sudo apt-get install emacs && emacs --version
+        git clone https://github.com/riscy/melpazoid.git ~/melpazoid
+        pip install ~/melpazoid
+    - name: Run
+      env:
+        LOCAL_REPO: ${{ github.workspace }}
+        # RECIPE is your recipe as written for MELPA:
+        RECIPE: (jira :fetcher github :repo "unmonoqueteclea/jira.el")
+        # set this to false (or remove it) if the package isn't on MELPA:
+        EXIST_OK: false
+      run: echo $GITHUB_REF && make -C ~/melpazoid

jira-actions.el

@@ -70,7 +70,7 @@
            (,(concat "--comment=" (jira-utils-marked-item)
                      ": " (jira-actions--marked-issue-description))
             ,(concat "--date="
-                     (format-time-string "%Y-%m-%dT%H:%M:%S.%3N%z" (current-time)))
+                     (format-time-string "%FT%T.%3N%z" (current-time)))
             "--time=1h"))
   ["Arguments"
    ("n" "Notify users" "--notify-users")

jira-api.el

@@ -96,7 +96,8 @@
 (cl-defun jira-api-call (verb endpoint &key params data callback)
   "Perform a VERB request to the Jira API ENDPOINT.
 
-PARAMS is a list of cons cells, DATA is the request body, and CALLBACK is the function to call if successful."
+PARAMS is a list of cons cells, DATA is the request body, and CALLBACK
+is the function to call if successful."
   (message "[Jira API Call]: %s %s" verb endpoint)
   (let ((auth (jira-api--auth-header jira-username jira-token)))
     (request

jira-detail.el

@@ -70,24 +70,18 @@
         (ratio (jira-detail--issue-fmt issue :work-ratio))
         (fix-versions (jira-detail--issue-fmt issue :fix-versions))
         (summary (jira-detail--issue-fmt issue :summary)))
-    (insert (concat (jira-detail--header "Issue Key")
-                    key " (" type")\n"))
-    (insert (concat (jira-detail--header "Status")
-                    status))
+    (insert (jira-detail--header "Issue Key") key " (" type")\n")
+    (insert (jira-detail--header "Status") status)
     (if (and resolution (not (string= resolution "")))
-        (insert (concat " (" resolution ")\n"))
+        (insert " (" resolution ")\n")
       (insert "\n"))
-    (insert (concat (jira-detail--header "Project")
-                    project "\n"))
-    (insert (concat (jira-detail--header "Time")
-                    estimate
-                    " (remaining: " remaining ")\n"))
-    (insert (concat (jira-detail--header "Work Ratio")
-                    ratio "\n"))
-    (insert (concat (jira-detail--header "Fix Versions")
-                    fix-versions "\n"))
-    (insert (concat (jira-detail--header "Summary")
-                    summary "\n"))))
+    (insert (jira-detail--header "Project") project "\n")
+    (insert (jira-detail--header "Time")
+            estimate
+            " (remaining: " remaining ")\n")
+    (insert (jira-detail--header "Work Ratio") ratio "\n")
+    (insert (jira-detail--header "Fix Versions") fix-versions "\n")
+    (insert (jira-detail--header "Summary") summary "\n")))
 
 
 (defun jira-detail--issue-team (issue)
@@ -98,11 +92,11 @@
         (parent-status (jira-detail--issue-fmt issue :parent-status))
         (sprint (jira-detail--issue-fmt issue :sprints))
         (components (jira-detail--issue-fmt issue :components)))
-    (insert (concat (jira-detail--header "Business Line") line "\n"))
-    (insert (concat (jira-detail--header "Parent")
-                    parent-key " (" parent-type ") (" parent-status ")\n"))
-    (insert (concat (jira-detail--header "Sprint") sprint "\n"))
-    (insert (concat (jira-detail--header "Components") components "\n"))))
+    (insert (jira-detail--header "Business Line") line "\n")
+    (insert (jira-detail--header "Parent")
+            parent-key " (" parent-type ") (" parent-status ")\n")
+    (insert (jira-detail--header "Sprint") sprint "\n")
+    (insert (jira-detail--header "Components") components "\n")))
 
 (defun jira-detail--issue-manager-data (issue)
   "Show the manager data of the ISSUE."
@@ -112,12 +106,12 @@
         (assignee (jira-detail--issue-fmt issue :assignee-name))
         (reporter (jira-detail--issue-fmt issue :reporter-name))
         (due-date (jira-detail--issue-fmt issue :due-date)))
-    (insert (concat (jira-detail--header "Cost Center") cost-center "\n"))
-    (insert (concat (jira-detail--header "Priority") priority "\n"))
-    (insert (concat (jira-detail--header "Labels") labels "\n"))
-    (insert (concat (jira-detail--header "Assignee")  assignee "\n"))
-    (insert (concat (jira-detail--header "Reporter") reporter "\n"))
-    (insert (concat (jira-detail--header "Due Date") due-date "\n"))))
+    (insert (jira-detail--header "Cost Center") cost-center "\n")
+    (insert (jira-detail--header "Priority") priority "\n")
+    (insert (jira-detail--header "Labels") labels "\n")
+    (insert (jira-detail--header "Assignee")  assignee "\n")
+    (insert (jira-detail--header "Reporter") reporter "\n")
+    (insert (jira-detail--header "Due Date") due-date "\n")))
 
 (defun jira-detail--description (issue)
   "Show the description of the ISSUE."

jira-fmt.el

@@ -102,7 +102,7 @@ COLOR-TODAY is a boolean to color the date if it is today."
   (when (not (string-empty-p date))
       (let ((value (concat date ", " (jira-utils-get-day-of-week date))))
         (if (and color-today
-                 (string= date (format-time-string "%Y-%m-%d" (current-time))))
+                 (string= date (format-time-string "%F" (current-time))))
             (propertize value  'face 'jira-face-date-today)
           (propertize value  'face 'jira-face-date)))))
 

jira-issues.el

@@ -212,12 +212,11 @@
 
   (setq tabulated-list-sort-key (cons "Status" nil))
   (setq tabulated-list-padding 2)
-  (add-hook 'tabulated-list-revert-hook 'jira-issues--refresh nil t)
+  (add-hook 'tabulated-list-revert-hook #'jira-issues--refresh nil t)
+  (add-hook 'jira-issues-changed-hook #'tablist-revert)
   (tabulated-list-init-header)
   (tablist-minor-mode))
 
-(add-hook 'jira-issues-changed-hook 'tablist-revert)
-
 (provide 'jira-issues)
 
 ;;; jira-issues.el ends here

jira-tempo.el

@@ -168,7 +168,7 @@ CALLBACK is a function that will be called with the worklogs data."
                       (list (funcall name field) (funcall columns field) t))
                     jira-tempo-table-fields))))
   (setq tabulated-list-padding 2)
-  (add-hook 'tabulated-list-revert-hook 'jira-tempo--refresh nil t)
+  (add-hook 'tabulated-list-revert-hook #'jira-tempo--refresh nil t)
   (tabulated-list-init-header)
   (tablist-minor-mode)
   (tabulated-list-revert)

jira-utils.el

@@ -169,8 +169,7 @@ with the given PREFIX."
          (days-from-monday (mod (- current-day 1) 7))
          (start-of-week (time-subtract date (days-to-time days-from-monday)))
          (end-of-week (time-add start-of-week (days-to-time 6)))
-         (format-time (lambda (time)
-                        (format-time-string "%Y-%m-%d" time))))
+         (format-time (lambda (time) (format-time-string "%F" time))))
     (list (funcall format-time start-of-week)
           (funcall format-time end-of-week))))