Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: v1.1.2 breaks date objects being passed as query params #128

Open
rhuanbarreto opened this issue Sep 3, 2024 · 1 comment · May be fixed by #129
Open

Regression: v1.1.2 breaks date objects being passed as query params #128

rhuanbarreto opened this issue Sep 3, 2024 · 1 comment · May be fixed by #129

Comments

@rhuanbarreto
Copy link

In this PR: #115 it added support for objects, but it broke support for adding other object-alike values (typeof value === "object"), like Date's.
@rhuanbarreto rhuanbarreto linked a pull request Sep 4, 2024 that will close this issue
Open
@apescione
Copy link

this version append double quotas:

?startDate="2024-10-05T22:00:00.000Z"&endDate="2024-10-12T22:00:00.000Z"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: treat cases where query params can be null or Dates rhuanbarreto/eden
2 participants
@rhuanbarreto @apescione