-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include other editors than JetBrains in the .gitignore #20
Comments
Yes, please go ahead, thanks. |
Honestly, the .gitignore is some kinda of crazy... why such an elaborate one? These are things that should be configured on a case by case basis... and really, many of these feel as though they belong in user dir, vs project dir. |
A ~600 line default .gitignore is just asking for trouble... and is going to scare off new users from editing it to tune to constantly changing needs. |
@bluepeter What do you suggest? Maybe we can promote one of these |
I'm not sure, but this feels honestly counterproductive. Some people will assume this is the "default" and go with it. As a result, they will get something completely counterproductive such as:
... which I can't ever imagine every being useful? I'd honestly scrap it. It requires too much configuration. Havent' looked at any of the generators. Perhaps, instead, give some common-sense advice on rationale behind .gitignore strategies... e.g., why they shouldn't check-in node-modules/ etc. |
It is very unweildy at the moment the .gitignore - perhaps the suggestion here is not to include ALL of this as what you'd include in your project but examples for common project types? Or groupings for tech types? It's always handy having a gitignore to hand when starting a new project |
@bluepeter is right. keep your IDE ignores on your machine. Nobody needs to ignore an enitre IntellIJ IDEA file-based project structure when they use tmux+vim for development. Best to keep .gitignore focussed on global ignores specific to the project. |
The reason I put editors in there was based on my own experience. I had to delete someone else's |
@vpanjganj and I absolutely have experienced the same thing - but rather than pollute |
I see the need to ignore
I actually agree with @bluepeter on this one. From what I understand, that Maybe we can expand on the section for Thoughts? |
I would just add rules to the gitignore that are related to the project, not the editor. For example, node_modules and .log files. Other things should be globally ignored by the user. |
I think the current config for
I agree with that as well, I think this file should be trimmed down.
I think we stick to be guidelines for JavaScript projects for now and do it right, this also prevents the docs from getting enormous. My suggestion is:
|
You know what, I think you're right. |
If I were to create a new project I'd start with an empty .gitignore. I'd then add *.log, and node_modules in the first few commits. Beyond that my .gitignore files are generally quite empty, for frontend projects I'm likely to add an ignore for a babelified/compiled/thirdparty directory perhaps. How about rather than massively engineering a very simple file and encouraging blind copy+paste, you simply add the basic javascript defaults, then have a quick summary of how to encourage local ignores, and then guidelines on what things a user might add to the file, and how they might do it. I think that way it becomes educational, hence a guideline, but also good as a basic seed for building a node project. |
Working in different companies and various teams, I've noticed not many
have a .gitignore_global and for that reason, I think we shouldn't fully
ignore editor settings.
@vpanjganj whoops, sorry that's my bad. I didn't notice that in the existing
.gitignore.
Yes, agreed. Let's stick to JS projects. I was just trying to get a point
across. 😊
As for major JS IDEs, Webstorm comes to mind, but I can't think of anything
else. Editors however, there are many. Almost an endless list.
To ignore Node stuff, we can just do a gitignore.io/api/node. That's what I do
for my personal projects.
|
Hey guys, What do you think of this as a quick fix?:
Any thought?
@antony Sounds like a good idea do you think you can come up with something? |
@vpanjganj looks much, much better than the original |
@vpanjganj I'll have a go yeah |
New proposal for |
Hello,
I would like to include some other editors such as Eclipse in the workspace exclude for the .gitignore.
Happy to PR if you feel appropriate
The text was updated successfully, but these errors were encountered: