Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP2 support #78

Open
lpil opened this issue Nov 13, 2019 · 5 comments
Open

HTTP2 support #78

lpil opened this issue Nov 13, 2019 · 5 comments

Comments

@lpil
Copy link
Contributor

lpil commented Nov 13, 2019

It's be great to have HTTP2 support in Elli!

This seems like quite an ambitious addition but I thought I'd open an issue anyway :)

@tsloughter
Copy link
Member

@lpil I don't think it should ever be added to elli itself, which is why I created https://github.com/elli-lib/elli_chatterbox.

Obviously issue being they don't have a shared form of request and configuration, all they share is the tcp acceptor which based on if you send a h2 upgrade in ssl it goes to http2.

But this could be built on to provide a shared interface for both while keeping it not added it directly into elli itself.

@yurrriq
Copy link
Member

yurrriq commented Nov 13, 2019

👍 to shared interface and an example in https://github.com/elli-lib/elli-examples

@yurrriq
Copy link
Member

yurrriq commented Feb 2, 2021

Opened elli-lib/elli-examples#8

@yurrriq yurrriq closed this as completed Feb 2, 2021
@yurrriq yurrriq reopened this Feb 2, 2021
@yurrriq
Copy link
Member

yurrriq commented Feb 2, 2021

Is there some way we could use the Plug design for the shared interface?

@tsloughter
Copy link
Member

I wouldn't.

But I'd be open to reviving https://github.com/tsloughter/elna, just not sure if there is a user base out there.

Also, I've been meaning to merge in an acceptor_pool interface to chatterbox and submit one for elli, then they'll both be easily combined, tho with their own handlers, so only useful for those who have a specific use-case where they want the http1/http2 to be handled by separate modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants