Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): notification like avatar not shrink (#2893) #2897

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cxroop
Copy link

@cxroop cxroop commented Jun 29, 2024

fix #2893

before

image

after

elk
image
image

Copy link

netlify bot commented Jun 29, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 1872522
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/667f866347aac30008cfd71a
😎 Deploy Preview https://deploy-preview-2897--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 29, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 1872522
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/667f8663b7a8870008181990

@cxroop cxroop changed the title fix(ui): notification like avatar not shrink fix(ui): notification like avatar not shrink (#2893) Jun 29, 2024
@ayoayco
Copy link
Member

ayoayco commented Aug 10, 2024

Thanks for the PR. Fix and refactor looks clean.

I think the only scenario we want to look at now is what if there's only a few accounts that interacted and the label is below the avatars. Does it still look good?

@shuuji3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aspect ratio avatars when a lot of people favorite your post is wrong
2 participants