Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidateImpexAction doesn't use configured hostname #26

Open
bjmi opened this issue Mar 18, 2017 · 1 comment
Open

ValidateImpexAction doesn't use configured hostname #26

bjmi opened this issue Mar 18, 2017 · 1 comment

Comments

@bjmi
Copy link

bjmi commented Mar 18, 2017

The default hostname string "http://localhost:9001/hac" is always used for validation action and not the configured url in preference page.
In
ValidateImpexAction

final String hostName = store.getDefaultString(PreferenceConstants.P_HOST_ENDPOINT_STRING);
should be replaced with
String hostName = store.getString(PreferenceConstants.P_HOST_ENDPOINT_STRING);

Please also rename the label "Host name:" to "URL to HAC:" or something that better express that it must be a URL.

@eljoujat
Copy link
Owner

eljoujat commented Apr 4, 2017

Hello @bjmi
Thanks for the issue 👍 . I'm able to reproduce and i will fix it next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants