chore: add credo fixes #296
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding Credo is probably a great idea, but I don't think that I'll merge this quite yet since that's a bit of a different decision from the changes themselves. Unfortunately this repo hasn't received a lot of maintainer love for a long time now, so I feel like we need an update-to-date, holistic perspective in order to integrate project-level changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
Introducing a few Credo-related changes:
CaseClauseErrorwas being raised. This issue was tracked and fixed on Credo's repo, and seems to happen as of Elixir version 1.17. The fix was released on Credo version 1.7.7.Readability.ModuleDoccheck@moduledoc falsedoc, there is no point in having this enforced style check, right?@moduledoc falselines.is_range?function name torange?, following the Readability.PredicateFunctionNames style for predicate functions.