Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - Generate function streams output #368

Open
lordsoffallen opened this issue Sep 30, 2024 · 2 comments
Open

BUG - Generate function streams output #368

lordsoffallen opened this issue Sep 30, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@lordsoffallen
Copy link

lordsoffallen commented Sep 30, 2024

According the code snippet here:
https://github.com/elevenlabs/elevenlabs-python/blob/main/src/elevenlabs/client.py#L225,

that should run only when stream=False but following that line leads to here:
https://github.com/elevenlabs/elevenlabs-python/blob/main/src/elevenlabs/text_to_speech/client.py#L122

which is where we client is being called via streaming endpoint and it actually yields, doesn't return.

Must be bug in the code, as I expect that function to not stream but return the full output. Am I missing something here?

@AngeloGiacco
Copy link
Collaborator

hi! thanks for the issue! our SDK has changed quite significantly since you raised this issue. can you confirm whether you are still having the issue, as the referenced code is out of date

@AngeloGiacco AngeloGiacco added the bug Something isn't working label Feb 4, 2025
@AngeloGiacco AngeloGiacco self-assigned this Feb 4, 2025
@AngeloGiacco
Copy link
Collaborator

confirmed this is an issue and have added a pr of a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants