Copy Room Link should work on DMs

[ara4n]

Steps to reproduce

Just because you've tagged a room as DM doesn't mea you don't want to be able to copy a link to it to refer to it in a different room.

Outcome

What did you expect?

Copy Link works on any room in the room list

What happened instead?

It only works on Rooms, not DMs

Operating system

macOS

Application version

nightly

How did you install the app?

nightly

Homeserver

matrix.org

Will you send logs?

No

[t3chguy]

This was chosen by product to not scare users into thinking that leaking such a link would let anyone into their private DMs

[t3chguy]

Related #19344

[ara4n]

i think the product thinking is incorrect here; you can have a link to something without having permission to follow that link.

[Johennes]

This strikes me as a fairly small use case because only you and the other person would be able to actually use that link. I had the counter example happen to me this week where I meant to share somebody's MXID and absentmindedly copied the room ID via the "Share room" option in the DM's right panel.

Given that we've consciously chosen to make it like it is today, I'm going to relabel this as enhancement.