From af2c6684ee3ca7a680a63ed6167a8d1ad5642a32 Mon Sep 17 00:00:00 2001 From: Alice Zhao <66543449+alicelovescake@users.noreply.github.com> Date: Mon, 8 Apr 2024 09:24:47 -0700 Subject: [PATCH] fix: add team_reviewers to requestReviewers (#276) * fix: add team_reviewers to requestReviewers * chore: move comment * chore: update team reviewer to just slug * fix: add backup case * refactor: update slug for readability --- src/utils.ts | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/utils.ts b/src/utils.ts index eb9c22e..1645dbd 100644 --- a/src/utils.ts +++ b/src/utils.ts @@ -407,23 +407,29 @@ export const tagBackportReviewers = async ({ user?: string; }) => { const reviewers = []; + const teamReviewers = []; if (DEFAULT_BACKPORT_REVIEW_TEAM) { - reviewers.push(DEFAULT_BACKPORT_REVIEW_TEAM); + // Optionally request a default review team for backports. + // Use team slug value. i.e electron/wg-releases => wg-releases + const slug = + DEFAULT_BACKPORT_REVIEW_TEAM.split('/')[1] || + DEFAULT_BACKPORT_REVIEW_TEAM; + teamReviewers.push(slug); } if (user) { const hasWrite = await checkUserHasWriteAccess(context, user); - // Optionally request a default review team for backports. // If the PR author has write access, also request their review. if (hasWrite) reviewers.push(user); } - if (reviewers.length > 0) { + if (Math.max(reviewers.length, teamReviewers.length) > 0) { await context.octokit.pulls.requestReviewers( context.repo({ pull_number: targetPrNumber, reviewers, + team_reviewers: teamReviewers, }), ); }