Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possiblity to pass appleApiKey as base64 string #181

Closed
KillerCodeMonkey opened this issue Mar 6, 2024 · 2 comments
Closed

Possiblity to pass appleApiKey as base64 string #181

KillerCodeMonkey opened this issue Mar 6, 2024 · 2 comments

Comments

@KillerCodeMonkey
Copy link
Contributor

KillerCodeMonkey commented Mar 6, 2024

Just a short question:

Is it possible to extend this wonderful tool to allow to pass the appleApiKey as a base64 string instead of a path?

Would be nice to allow using API-Keys in CI without the need of putting the file somewhere "unsafe".

E.g. in github actions just put the base64 content in a secret and use it there.

Thanks :)

@KillerCodeMonkey KillerCodeMonkey changed the title Possiblity to pass appleApiKey as base64 Possiblity to pass appleApiKey as base64 string Mar 6, 2024
@jannemecek
Copy link

I wish this was possible as well

@MarshallOfSound
Copy link
Member

We didn't choose this API, the notarytool command that actually submits stuff to apples servers takes in a parameter which is a filepath 🤷 We could wrap that into a "pass us the content" in our API, but then the "unsafe" behavior of writing it to disk would still occur you just wouldn't be aware it was happening which is IMO worse

OVERVIEW: Submit an archive to the Notary service

USAGE: notarytool submit [<options>] <file-path>

ARGUMENTS:
  <file-path>             Path to the archive

OPTIONS:
  -v, --verbose
  -k, --key <key>         App Store Connect API key. File system path to the private key.

@MarshallOfSound MarshallOfSound closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants