From 52d9c0e990fc60e57c583386c5986aaa5985366b Mon Sep 17 00:00:00 2001
From: Samuel Attard <sattard@slack-corp.com>
Date: Wed, 24 Jul 2019 12:05:39 -0700
Subject: [PATCH] fix: actually use the artifactSuffix when generating the
 filename (#111)

---
 src/artifact-utils.ts       |  8 +++++++-
 test/artifact-utils.spec.ts | 13 +++++++++++++
 2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/src/artifact-utils.ts b/src/artifact-utils.ts
index 7e968c349..8ed32111f 100644
--- a/src/artifact-utils.ts
+++ b/src/artifact-utils.ts
@@ -27,7 +27,13 @@ export function getArtifactFileName(
 
   ensureIsTruthyString(details, 'platform');
   ensureIsTruthyString(details, 'arch');
-  return `${[details.artifactName, details.version, details.platform, details.arch].join('-')}.zip`;
+  return `${[
+    details.artifactName,
+    details.version,
+    details.platform,
+    details.arch,
+    ...(details.artifactSuffix ? [details.artifactSuffix] : []),
+  ].join('-')}.zip`;
 }
 
 function mirrorVar(name: keyof MirrorOptions, options: MirrorOptions, defaultValue: string) {
diff --git a/test/artifact-utils.spec.ts b/test/artifact-utils.spec.ts
index c7637e1c8..851356461 100644
--- a/test/artifact-utils.spec.ts
+++ b/test/artifact-utils.spec.ts
@@ -36,5 +36,18 @@ describe('artifact-utils', () => {
         }),
       ).toMatchInlineSnapshot(`"chromedriver-v1.0.1-android-ia32.zip"`);
     });
+
+    it('should return the correct hypenated artifact names for artifacts with a suffix', () => {
+      expect(
+        getArtifactFileName({
+          isGeneric: false,
+          artifactName: 'electron',
+          version: 'v1.0.1',
+          platform: 'darwin',
+          arch: 'x64',
+          artifactSuffix: 'symbols',
+        }),
+      ).toMatchInlineSnapshot(`"electron-v1.0.1-darwin-x64-symbols.zip"`);
+    });
   });
 });